Oilpan: Replace RefPtrs to Node and its subclasses in core/xml/ with Oilpan transition types.

Oilpan: Replace RefPtrs to Node and its subclasses in core/xml/ with Oilpan transition types.

This CL replaces RefPtrs in DOMImplementation because DOMParser uses
DOMImplementation.

BUG=357163
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174676

[tkent, 2014-05-23 03:37:38]

Please review this.

[haraken, 2014-05-23 05:38:19]

https://codereview.chromium.org/288343017/diff/20001/Source/core/frame/DOMWin...
File Source/core/frame/DOMWindow.cpp (right):

https://codereview.chromium.org/288343017/diff/20001/Source/core/frame/DOMWin...
Source/core/frame/DOMWindow.cpp:368: RefPtrWillBeRawPtr<Document> document;

I guess we decided to explicitly initialize this kind of pointer with nullptr,
even if the initialization is covered in the below branches.

https://codereview.chromium.org/288343017/diff/20001/Source/core/frame/DOMWin...
Source/core/frame/DOMWindow.cpp:393: return m_document.get();

Document is now on the heap, so can we just make m_document a Member in this CL?

https://codereview.chromium.org/288343017/diff/20001/Source/core/frame/DOMWin...
Source/core/frame/DOMWindow.cpp:416: return m_document.get();

Ditto.

https://codereview.chromium.org/288343017/diff/20001/Source/core/xml/XSLTProc...
File Source/core/xml/XSLTProcessor.cpp (right):

https://codereview.chromium.org/288343017/diff/20001/Source/core/xml/XSLTProc...
Source/core/xml/XSLTProcessor.cpp:70: RefPtrWillBeRawPtr<Document> result;

= nullptr

[sof, 2014-05-23 05:43:51]

https://codereview.chromium.org/288343017/diff/20001/Source/core/frame/DOMWin...
File Source/core/frame/DOMWindow.cpp (right):

https://codereview.chromium.org/288343017/diff/20001/Source/core/frame/DOMWin...
Source/core/frame/DOMWindow.cpp:393: return m_document.get();
On 2014/05/23 05:38:20, haraken wrote:
> 
> Document is now on the heap, so can we just make m_document a Member in this
CL?

Not much to it, I had to do this for https://codereview.chromium.org/292503006/
to fix some failing fast/xsl/ tests.

[sof, 2014-05-23 06:11:20]

https://codereview.chromium.org/288343017/diff/20001/Source/core/xml/XSLTProc...
File Source/core/xml/XSLTProcessor.h (right):

https://codereview.chromium.org/288343017/diff/20001/Source/core/xml/XSLTProc...
Source/core/xml/XSLTProcessor.h:56: void importStylesheet(PassRefPtr<Node>
style)
PassRefPtrWillBeRawPtr<> here also?

[tkent, 2014-05-23 06:21:46]

https://codereview.chromium.org/288343017/diff/20001/Source/core/frame/DOMWin...
File Source/core/frame/DOMWindow.cpp (right):

https://codereview.chromium.org/288343017/diff/20001/Source/core/frame/DOMWin...
Source/core/frame/DOMWindow.cpp:368: RefPtrWillBeRawPtr<Document> document;
On 2014/05/23 05:38:20, haraken wrote:
> 
> I guess we decided to explicitly initialize this kind of pointer with nullptr,
> even if the initialization is covered in the below branches.

Done.

https://codereview.chromium.org/288343017/diff/20001/Source/core/frame/DOMWin...
Source/core/frame/DOMWindow.cpp:393: return m_document.get();
On 2014/05/23 05:38:20, haraken wrote:
> 
> Document is now on the heap, so can we just make m_document a Member in this
CL?

I want to avoid it because I don't understand lifetime of DOMWindow and Document
clearly.

https://codereview.chromium.org/288343017/diff/20001/Source/core/frame/DOMWin...
Source/core/frame/DOMWindow.cpp:393: return m_document.get();
On 2014/05/23 05:43:52, sof wrote:
> On 2014/05/23 05:38:20, haraken wrote:
> > 
> > Document is now on the heap, so can we just make m_document a Member in this
> CL?
> 
> Not much to it, I had to do this for
https://codereview.chromium.org/292503006/
> to fix some failing fast/xsl/ tests.

Wow, conflict!

https://codereview.chromium.org/288343017/diff/20001/Source/core/xml/XSLTProc...
File Source/core/xml/XSLTProcessor.cpp (right):

https://codereview.chromium.org/288343017/diff/20001/Source/core/xml/XSLTProc...
Source/core/xml/XSLTProcessor.cpp:70: RefPtrWillBeRawPtr<Document> result;
On 2014/05/23 05:38:20, haraken wrote:
> 
> = nullptr

Done.

https://codereview.chromium.org/288343017/diff/20001/Source/core/xml/XSLTProc...
File Source/core/xml/XSLTProcessor.h (right):

https://codereview.chromium.org/288343017/diff/20001/Source/core/xml/XSLTProc...
Source/core/xml/XSLTProcessor.h:56: void importStylesheet(PassRefPtr<Node>
style)
On 2014/05/23 06:11:20, sof wrote:
> PassRefPtrWillBeRawPtr<> here also?

Done.

[sof, 2014-05-23 06:23:50]

https://codereview.chromium.org/288343017/diff/20001/Source/core/frame/DOMWin...
File Source/core/frame/DOMWindow.cpp (right):

https://codereview.chromium.org/288343017/diff/20001/Source/core/frame/DOMWin...
Source/core/frame/DOMWindow.cpp:393: return m_document.get();
On 2014/05/23 06:21:47, tkent wrote:
> On 2014/05/23 05:43:52, sof wrote:
> > On 2014/05/23 05:38:20, haraken wrote:
> > > 
> > > Document is now on the heap, so can we just make m_document a Member in
this
> > CL?
> > 
> > Not much to it, I had to do this for
> https://codereview.chromium.org/292503006/
> > to fix some failing fast/xsl/ tests.
> 
> Wow, conflict!
> 

I will wait and rebase (there's too many CLs flying in :) )

[haraken, 2014-05-23 06:37:49]

LGTM

[tkent, 2014-05-23 08:50:26]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-05-23 08:51:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/288343017/40001

[commit-bot: I haz the power, 2014-05-23 10:44:26]

Change committed as 174676