Oilpan: Replace RefPtrs to Node and its subclasses in core/xml/ with Oilpan transition types.

Source/core/frame/DOMWindow.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 345 matching lines @@
 }
 
 void DOMWindow::clearEventQueue()
 {
     if (!m_eventQueue)
         return;
     m_eventQueue->close();
     m_eventQueue.clear();
 }
 
-PassRefPtr<Document> DOMWindow::createDocument(const String& mimeType, const DocumentInit& init, bool forceXHTML)
+PassRefPtrWillBeRawPtr<Document> DOMWindow::createDocument(const String& mimeType, const DocumentInit& init, bool forceXHTML)
 {
-    RefPtr<Document> document;
+    RefPtrWillBeRawPtr<Document> document;

[haraken, 2014/05/23 05:38:20]

I guess we decided to explicitly initialize this kind of pointer with nullptr,
even if the initialization is covered in the below branches.

[tkent, 2014/05/23 06:21:47]

Done.

     if (forceXHTML) {
         // This is a hack for XSLTProcessor. See XSLTProcessor::createDocumentFromSource().
         document = Document::create(init);
     } else {
         document = DOMImplementation::createDocument(mimeType, init, init.frame() ? init.frame()->inViewSourceMode() : false);
         if (document->isPluginDocument() && document->isSandboxed(SandboxPlugins))
             document = SinkDocument::create(init);
     }
 
     return document.release();
 }
 
-PassRefPtr<Document> DOMWindow::installNewDocument(const String& mimeType, const DocumentInit& init, bool forceXHTML)
+PassRefPtrWillBeRawPtr<Document> DOMWindow::installNewDocument(const String& mimeType, const DocumentInit& init, bool forceXHTML)
 {
     ASSERT(init.frame() == m_frame);
 
     clearDocument();
 
     m_document = createDocument(mimeType, init, forceXHTML);
     m_eventQueue = DOMWindowEventQueue::create(m_document.get());
     m_document->attach();
 
-    if (!m_frame)
-        return m_document;
+    if (!m_frame) {
+        // FIXME: Oilpan: Remove .get() when m_document becomes Member<>.
+        return m_document.get();

[haraken, 2014/05/23 05:38:20]

Document is now on the heap, so can we just make m_document a Member in this CL?

[sof, 2014/05/23 05:43:52]

Not much to it, I had to do this for https://codereview.chromium.org/292503006/
to fix some failing fast/xsl/ tests.

[tkent, 2014/05/23 06:21:47]

I want to avoid it because I don't understand lifetime of DOMWindow and Document
clearly.

[tkent, 2014/05/23 06:21:47]

Wow, conflict!

[sof, 2014/05/23 06:23:51]

I will wait and rebase (there's too many CLs flying in :) )

+    }
 
     m_frame->script().updateDocument();
     m_document->updateViewportDescription();
 
     if (m_frame->page() && m_frame->view()) {
         if (ScrollingCoordinator* scrollingCoordinator = m_frame->page()->scrollingCoordinator()) {
             scrollingCoordinator->scrollableAreaScrollbarLayerDidChange(m_frame->view(), HorizontalScrollbar);
             scrollingCoordinator->scrollableAreaScrollbarLayerDidChange(m_frame->view(), VerticalScrollbar);
             scrollingCoordinator->scrollableAreaScrollLayerDidChange(m_frame->view());
         }
     }
 
     m_frame->selection().updateSecureKeyboardEntryIfActive();
 
     if (m_frame->isMainFrame()) {
         m_frame->notifyChromeClientWheelEventHandlerCountChanged();
         if (m_document->hasTouchEventHandlers())
             m_frame->host()->chrome().client().needTouchEvents(true);
     }
 
-    return m_document;
+    // FIXME: Oilpan: Remove .get() when m_document becomes Member<>.
+    return m_document.get();

[haraken, 2014/05/23 05:38:20]

Ditto.

 }
 
 EventQueue* DOMWindow::eventQueue() const
 {
     return m_eventQueue.get();
 }
 
 void DOMWindow::enqueueWindowEvent(PassRefPtrWillBeRawPtr<Event> event)
 {
     if (!m_eventQueue)
@@ skipping 1462 matching lines @@
     visitor->trace(m_media);
     visitor->trace(m_sessionStorage);
     visitor->trace(m_localStorage);
     visitor->trace(m_applicationCache);
     visitor->trace(m_performance);
     visitor->trace(m_css);
     WillBeHeapSupplementable<DOMWindow>::trace(visitor);
 }
 
 } // namespace WebCore