Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 288343009: Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) (Closed)

Created:
6 years, 7 months ago by reed1
Modified:
6 years, 7 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14830

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : SK_SUPPORT_LEGACY_DEADUNITMAPPERTYPE is unneeded #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -780 lines) Patch
M bench/GradientBench.cpp View 8 chunks +18 lines, -29 lines 0 comments Download
M expectations/gm/ignored-tests.txt View 1 chunk +13 lines, -1 line 0 comments Download
M experimental/SkiaExamples/HelloSkiaExample.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M experimental/webtry/templates/template.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/alphagradients.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/colortype.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/convexpolyclip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/drawbitmaprect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradientDirtyLaundry.cpp View 2 chunks +9 lines, -14 lines 0 comments Download
M gm/gradient_matrix.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/gradients.cpp View 7 chunks +17 lines, -24 lines 0 comments Download
M gm/gradients_2pt_conical.cpp View 20 chunks +37 lines, -65 lines 0 comments Download
M gm/gradients_no_texture.cpp View 4 chunks +13 lines, -20 lines 0 comments Download
M gm/shaderbounds.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadertext.cpp View 5 chunks +13 lines, -27 lines 0 comments Download
M gm/shadertext2.cpp View 2 chunks +1 line, -8 lines 0 comments Download
M gm/shadertext3.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M gm/tilemodes.cpp View 2 chunks +1 line, -9 lines 0 comments Download
M gm/tilemodes_scaled.cpp View 2 chunks +1 line, -9 lines 0 comments Download
M gyp/SampleApp.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/public_headers.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M gyp/utils.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M include/core/SkFlattenable.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPicture.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkReadBuffer.h View 3 chunks +6 lines, -2 lines 0 comments Download
D include/core/SkUnitMapper.h View 1 chunk +0 lines, -37 lines 0 comments Download
M include/effects/SkGradientShader.h View 1 2 6 chunks +30 lines, -67 lines 0 comments Download
M samplecode/SampleAll.cpp View 3 chunks +2 lines, -7 lines 0 comments Download
M samplecode/SampleGradients.cpp View 4 chunks +14 lines, -21 lines 0 comments Download
M samplecode/SampleLayers.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SamplePatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleShaderText.cpp View 5 chunks +13 lines, -27 lines 0 comments Download
M samplecode/SampleSlides.cpp View 4 chunks +11 lines, -18 lines 0 comments Download
M samplecode/SampleTiling.cpp View 2 chunks +1 line, -9 lines 0 comments Download
D samplecode/SampleUnitMapper.cpp View 1 chunk +0 lines, -172 lines 0 comments Download
M samplecode/SampleVertices.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawGradient.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/animator/SkDrawGradient.cpp View 5 chunks +3 lines, -49 lines 0 comments Download
M src/core/SkReadBuffer.cpp View 1 chunk +22 lines, -0 lines 0 comments Download
M src/core/SkValidatingReadBuffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkValidatingReadBuffer.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 20 chunks +13 lines, -62 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 3 chunks +0 lines, -3 lines 0 comments Download
D src/utils/SkUnitMappers.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
reed1
basically the same as before. Previously was reverted because of old-style client calls in chrome/blink. ...
6 years, 7 months ago (2014-05-21 13:48:44 UTC) #1
scroggo
lgtm https://codereview.chromium.org/288343009/diff/1/gyp/skia_for_chromium_defines.gypi File gyp/skia_for_chromium_defines.gypi (right): https://codereview.chromium.org/288343009/diff/1/gyp/skia_for_chromium_defines.gypi#newcode16 gyp/skia_for_chromium_defines.gypi:16: 'SK_SUPPORT_LEGACY_DEADUNITMAPPERTYPE', Didn't you say you fixed the call ...
6 years, 7 months ago (2014-05-21 14:03:34 UTC) #2
reed1
On 2014/05/21 14:03:34, scroggo wrote: > lgtm > > https://codereview.chromium.org/288343009/diff/1/gyp/skia_for_chromium_defines.gypi > File gyp/skia_for_chromium_defines.gypi (right): > ...
6 years, 7 months ago (2014-05-21 16:42:38 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 7 months ago (2014-05-21 19:49:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/288343009/40001
6 years, 7 months ago (2014-05-21 19:50:24 UTC) #5
commit-bot: I haz the power
Change committed as 14830
6 years, 7 months ago (2014-05-21 19:57:12 UTC) #6
reed2
6 years, 7 months ago (2014-05-22 02:54:30 UTC) #7
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/296823008/ by reed@chromium.org.

The reason for reverting is: required blink change failed to land.

Powered by Google App Engine
This is Rietveld 408576698