Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2883423003: Added -[CRWWKNavigationStates pendingNavigations] API. (Closed)

Created:
3 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 7 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added -[CRWWKNavigationStates pendingNavigations] API. This method returns all navigations that are currently pending (REQUESTED, STARTED, REDIRECTED), including null navigations, which are represented with NSNull. This API will be used in dependent CL to allow looking up for a pending navigation by URL. BUG=713836 Review-Url: https://codereview.chromium.org/2883423003 Cr-Commit-Position: refs/heads/master@{#472526} Committed: https://chromium.googlesource.com/chromium/src/+/7ebdb138f42c121d85e25821a24f864e8a380d05

Patch Set 1 #

Patch Set 2 : Self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -0 lines) Patch
M ios/web/web_state/ui/crw_wk_navigation_states.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states.mm View 1 chunk +13 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm View 1 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Eugene But (OOO till 7-30)
3 years, 7 months ago (2017-05-16 22:21:31 UTC) #5
kkhorimoto
lgtm
3 years, 7 months ago (2017-05-17 18:44:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883423003/20001
3 years, 7 months ago (2017-05-17 18:50:28 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 19:18:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7ebdb138f42c121d85e25821a24f...

Powered by Google App Engine
This is Rietveld 408576698