Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2883393003: [Payments] No longer resize Autofill assets in Payments/Autofill UI (Closed)

Created:
3 years, 7 months ago by Mathieu
Modified:
3 years, 7 months ago
Reviewers:
sdefresne, Moe
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), mathp+autofillwatch_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] No longer resize and have borders around Autofill assets On iOS, the assets were being resized needlessly and borders were added. They will now always be the asset size of 32x20dp and the border is in the asset. BUG=722651 TBR=jdonnelly Review-Url: https://codereview.chromium.org/2883393003 Cr-Commit-Position: refs/heads/master@{#472465} Committed: https://chromium.googlesource.com/chromium/src/+/888a72fe40428af01d6b47d0891de462e6062f2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -24 lines) Patch
M ios/chrome/browser/ui/autofill/cells/autofill_edit_item.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/payments/cells/accepted_payment_methods_item.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/payments/credit_card_edit_mediator.mm View 3 chunks +3 lines, -11 lines 0 comments Download
M ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Mathieu
Hi Moe and Sylvain, PTAL for your respective directories
3 years, 7 months ago (2017-05-17 13:35:16 UTC) #4
sdefresne
lgtm
3 years, 7 months ago (2017-05-17 13:42:32 UTC) #6
Moe
LGTM
3 years, 7 months ago (2017-05-17 15:45:10 UTC) #7
Mathieu
TBR justin for the autofill file
3 years, 7 months ago (2017-05-17 15:45:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883393003/1
3 years, 7 months ago (2017-05-17 15:46:43 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 16:06:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/888a72fe40428af01d6b47d0891d...

Powered by Google App Engine
This is Rietveld 408576698