Upstream service worker "referer" tests to WPT

Upstream service worker "referer" tests to WPT

**referer**

This test exists in both WPT and the Chromium project tree. They differ
only in implementation details of the testing infrastructure.  However,
the upstream version suffers from timeout issues in the build
environment.

Rename the Chromium-specific version to reflect its deprecated status,
and re-enable the upstream version as an expected timeout.

**referrer-policy-header**

Move test file for automated contribution to the Web Platform Tests
project. Update URLs to use contextual values. Express asynchronous
sub-test using the `promise_test` function. Consistently remove iframe
regardless of sub-test result. Specify necessary HTTP headers in a
format that is supported by the Web Platform Tests project.

BUG=688116, 658997
R=falken@chromium.org

Review-Url: https://codereview.chromium.org/2883373002
Cr-Commit-Position: refs/heads/master@{#472902}
Committed: https://chromium.googlesource.com/chromium/src/+/74008fbe10dff1e03e4d5a9c941d6700705231df

[mike3, 2017-05-16 18:07:10]

Hi Matt--would you mind reviewing this for me?

[mike3, 2017-05-16 18:10:33]

Also, here's a comparison of the two project's versions of the "referer" test:

https://gist.github.com/jugglinmike/e8eb9efdbb8e32210def383760f8a2c9

[falken, 2017-05-17 05:13:47]

https://codereview.chromium.org/2883373002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/referrer-policy-header.https.html
(left):

https://codereview.chromium.org/2883373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/referrer-policy-header.https.html:28:
.catch(unreached_rejection(t));
I think we can't remove this unless we turn the test into a promise_test.

https://codereview.chromium.org/2883373002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/referrer-policy-header.https.html
(right):

https://codereview.chromium.org/2883373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/referrer-policy-header.https.html:8:
async_test(function(t) {
promise_test

https://codereview.chromium.org/2883373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/referrer-policy-header.https.html:26:
service_worker_unregister_and_done(t, SCOPE);
This should be reworked to be part of the promise chain.

[mike3, 2017-05-17 22:24:53]

This was a little sloppy on my part; sorry about that. Thanks for the review!

https://codereview.chromium.org/2883373002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/referrer-policy-header.https.html
(left):

https://codereview.chromium.org/2883373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/referrer-policy-header.https.html:28:
.catch(unreached_rejection(t));
On 2017/05/17 05:13:46, falken wrote:
> I think we can't remove this unless we turn the test into a promise_test.

Acknowledged.

https://codereview.chromium.org/2883373002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/referrer-policy-header.https.html
(right):

https://codereview.chromium.org/2883373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/referrer-policy-header.https.html:8:
async_test(function(t) {
On 2017/05/17 05:13:46, falken wrote:
> promise_test

Acknowledged.

https://codereview.chromium.org/2883373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/referrer-policy-header.https.html:26:
service_worker_unregister_and_done(t, SCOPE);
On 2017/05/17 05:13:46, falken wrote:
> This should be reworked to be part of the promise chain.

Acknowledged.

[falken, 2017-05-18 01:53:40]

lgtm, thanks

[mike3, 2017-05-18 17:50:16]

The CQ bit was checked by mike@mikepennisi.com

[commit-bot: I haz the power, 2017-05-18 17:51:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 19:35:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495129816508940,
"parent_rev": "9258f1b1b8e234f289aaf7bd2031c208ecca58ce", "commit_rev":
"74008fbe10dff1e03e4d5a9c941d6700705231df"}

[commit-bot: I haz the power, 2017-05-18 19:35:53]

Description was changed from

==========
Upstream service worker "referer" tests to WPT

**referer**

This test exists in both WPT and the Chromium project tree. They differ
only in implementation details of the testing infrastructure.  However,
the upstream version suffers from timeout issues in the build
environment.

Rename the Chromium-specific version to reflect its deprecated status,
and re-enable the upstream version as an expected timeout.

**referrer-policy-header**

Move test file for automated contribution to the Web Platform Tests
project. Update URLs to use contextual values. Express asynchronous
sub-test using the `promise_test` function. Consistently remove iframe
regardless of sub-test result. Specify necessary HTTP headers in a
format that is supported by the Web Platform Tests project.

BUG=688116, 658997
R=falken@chromium.org
==========

to

==========
Upstream service worker "referer" tests to WPT

**referer**

This test exists in both WPT and the Chromium project tree. They differ
only in implementation details of the testing infrastructure.  However,
the upstream version suffers from timeout issues in the build
environment.

Rename the Chromium-specific version to reflect its deprecated status,
and re-enable the upstream version as an expected timeout.

**referrer-policy-header**

Move test file for automated contribution to the Web Platform Tests
project. Update URLs to use contextual values. Express asynchronous
sub-test using the `promise_test` function. Consistently remove iframe
regardless of sub-test result. Specify necessary HTTP headers in a
format that is supported by the Web Platform Tests project.

BUG=688116, 658997
R=falken@chromium.org

Review-Url: https://codereview.chromium.org/2883373002
Cr-Commit-Position: refs/heads/master@{#472902}
Committed:
https://chromium.googlesource.com/chromium/src/+/74008fbe10dff1e03e4d5a9c941d...
==========

[commit-bot: I haz the power, 2017-05-18 19:35:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/74008fbe10dff1e03e4d5a9c941d...