Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2883353005: [LayoutNG] Refactor main-loop of block layout algorithm. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by ikilpatrick
Modified:
1 month ago
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Refactor main-loop of block layout algorithm. This just simplifies things by having clear paths for each type of child. There should be no functional changes. BUG=635619 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2883353005 Cr-Commit-Position: refs/heads/master@{#473077} Committed: https://chromium.googlesource.com/chromium/src/+/f1a94f90a612655f8deedeab50df2522d718c9fc

Patch Set 1 #

Patch Set 2 : rebase unused var. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -77 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 6 chunks +64 lines, -74 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.h View 1 chunk +4 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 22 (14 generated)
ikilpatrick
1 month ago (2017-05-18 17:07:17 UTC) #5
Gleb Lanbin
lgtm
1 month ago (2017-05-18 18:20:28 UTC) #10
atotic
lgtm
1 month ago (2017-05-18 18:43:13 UTC) #11
cbiesinger
nice, thanks!
1 month ago (2017-05-18 20:01:24 UTC) #13
blink-reviews
thanks! I've got one more i'm working on at the moment, which should fix a ...
1 month ago (2017-05-18 20:45:09 UTC) #16
chromium-reviews
thanks! I've got one more i'm working on at the moment, which should fix a ...
1 month ago (2017-05-18 20:45:09 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883353005/20001
1 month ago (2017-05-19 01:16:34 UTC) #19
commit-bot: I haz the power
1 month ago (2017-05-19 04:03:07 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f1a94f90a612655f8deedeab50df...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318