third_party/WebKit/Source/core/page/PrintContext.cpp - Issue 2883353002: Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/PrintContext.cpp

Issue 2883353002: Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate (Closed)

Patch Set: DCHECK in BluetoothCharacteristicProperties.cpp Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/PrintContext.cpp

diff --git a/third_party/WebKit/Source/core/page/PrintContext.cpp b/third_party/WebKit/Source/core/page/PrintContext.cpp

index 12bed3d6427b5c6f8ce4e2ba2c2fdc17ab33613b..4b60473f0423b4241e5c26cc501a976a129d8645 100644

--- a/third_party/WebKit/Source/core/page/PrintContext.cpp

+++ b/third_party/WebKit/Source/core/page/PrintContext.cpp

@@ -151,8 +151,8 @@ void PrintContext::ComputePageRectsWithPageSizeInternal(

}

void PrintContext::BeginPrintMode(float width, float height) {

- ASSERT(width > 0);

- ASSERT(height > 0);

+ DCHECK_GT(width, 0);

+ DCHECK_GT(height, 0);

// This function can be called multiple times to adjust printing parameters

// without going back to screen mode.