third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp - Issue 2883353002: Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

Issue 2883353002: Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate (Closed)

Patch Set: DCHECK in BluetoothCharacteristicProperties.cpp Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/LocalFrame.cpp ('K') | « third_party/WebKit/Source/core/frame/SuspendableTimer.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

index 95a1ec778a274ab4e4c048bf2e416961c5ebf766..1edfcc7adbdecfbc4a42c35f9c2e57310e229503 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

@@ -465,7 +465,7 @@ static void AddStringToDigestor(WebCryptoDigestor* digestor,

String InspectorAnimationAgent::CreateCSSId(blink::Animation& animation) {

String type =

id_to_animation_type_.at(String::Number(animation.SequenceNumber()));

- ASSERT(type != AnimationType::WebAnimation);

+ DCHECK_NE(type, AnimationType::WebAnimation);

KeyframeEffectReadOnly* effect = ToKeyframeEffectReadOnly(animation.effect());

Vector<CSSPropertyID> css_properties;