third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp - Issue 2883353002: Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp

Issue 2883353002: Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate (Closed)

Patch Set: DCHECK in BluetoothCharacteristicProperties.cpp Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp

diff --git a/third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp b/third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp

index 78cc9be4f32536309fcc43f18afdd00d5adc5441..2eb35697636960c2963dd75fd7f866622f4c8e17 100644

--- a/third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp

+++ b/third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp

@@ -70,8 +70,8 @@ HashAlgorithm SubresourceIntegrity::GetPrioritizedHashFunction(

const HashAlgorithm kWeakerThanSha512[] = {kHashAlgorithmSha256,

kHashAlgorithmSha384};

- ASSERT(algorithm1 != kHashAlgorithmSha1);

- ASSERT(algorithm2 != kHashAlgorithmSha1);

+ DCHECK_NE(algorithm1, kHashAlgorithmSha1);

+ DCHECK_NE(algorithm2, kHashAlgorithmSha1);

if (algorithm1 == algorithm2)

return algorithm1;