third_party/WebKit/Source/core/frame/DOMTimer.cpp - Issue 2883353002: Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMTimer.cpp

Issue 2883353002: Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate (Closed)

Patch Set: DCHECK in BluetoothCharacteristicProperties.cpp Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/DOMTimer.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMTimer.cpp b/third_party/WebKit/Source/core/frame/DOMTimer.cpp

index 40d6a6c3a2f4c1a332c69fbc68db3fd8faae7e65..b97d8d6e2b2065aaf7b3be3ad7781a139b9d3353 100644

--- a/third_party/WebKit/Source/core/frame/DOMTimer.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMTimer.cpp

@@ -81,7 +81,7 @@ DOMTimer::DOMTimer(ExecutionContext* context,

timeout_id_(timeout_id),

nesting_level_(context->Timers()->TimerNestingLevel() + 1),

action_(action) {

- ASSERT(timeout_id > 0);

+ DCHECK_GT(timeout_id, 0);

if (ShouldForwardUserGesture(interval, nesting_level_)) {

// Thread safe because shouldForwardUserGesture will only return true if

// execution is on the the main thread.