ios/chrome/app/main_controller.mm - Issue 2883323002: [ios] Fix clean shutdown of Chrome on iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/app/main_controller.mm

Issue 2883323002: [ios] Fix clean shutdown of Chrome on iOS. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/app/main_controller.mm

diff --git a/ios/chrome/app/main_controller.mm b/ios/chrome/app/main_controller.mm

index a45ae0a1aa6c73f7d89b2e8ee6fdd4a70cb3a493..f40141dbaf80b5168b7514e78566638829b0853c 100644

--- a/ios/chrome/app/main_controller.mm

+++ b/ios/chrome/app/main_controller.mm

@@ -953,6 +953,8 @@ enum class StackViewDismissalMode { NONE, NORMAL, INCOGNITO };

}

- (void)stopChromeMain {

+ _spotlightManager.reset();

rohitrao (ping after 24h) 2017/05/16 16:41:02 There's no guarantee that this call will destroy t

+ _browserViewWrangler.reset();

sdefresne 2017/05/16 16:44:40 There is no guarantee that this will destroy _brow

_chromeMain.reset();

}

« no previous file with comments | « no previous file | ios/chrome/app/spotlight/topsites_spotlight_manager.mm » ('j') | no next file with comments »