Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: ios/chrome/app/main_controller.mm

Issue 2883323002: [ios] Fix clean shutdown of Chrome on iOS. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ios/chrome/app/spotlight/topsites_spotlight_manager.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/app/main_controller.h" 5 #import "ios/chrome/app/main_controller.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 9
10 #import <CoreSpotlight/CoreSpotlight.h> 10 #import <CoreSpotlight/CoreSpotlight.h>
(...skipping 935 matching lines...) Expand 10 before | Expand all | Expand 10 after
946 afterDelay:delay]; 946 afterDelay:delay];
947 } 947 }
948 948
949 - (void)activateFirstUserActionRecorderWithBackgroundTime: 949 - (void)activateFirstUserActionRecorderWithBackgroundTime:
950 (NSTimeInterval)backgroundTime { 950 (NSTimeInterval)backgroundTime {
951 base::TimeDelta delta = base::TimeDelta::FromSeconds(backgroundTime); 951 base::TimeDelta delta = base::TimeDelta::FromSeconds(backgroundTime);
952 _firstUserActionRecorder.reset(new FirstUserActionRecorder(delta)); 952 _firstUserActionRecorder.reset(new FirstUserActionRecorder(delta));
953 } 953 }
954 954
955 - (void)stopChromeMain { 955 - (void)stopChromeMain {
956 _spotlightManager.reset();
rohitrao (ping after 24h) 2017/05/16 16:41:02 There's no guarantee that this call will destroy t
957 _browserViewWrangler.reset();
sdefresne 2017/05/16 16:44:40 There is no guarantee that this will destroy _brow
956 _chromeMain.reset(); 958 _chromeMain.reset();
957 } 959 }
958 960
959 - (BOOL)isTabSwitcherActive { 961 - (BOOL)isTabSwitcherActive {
960 return _tabSwitcherIsActive; 962 return _tabSwitcherIsActive;
961 } 963 }
962 964
963 #pragma mark - BrowserViewInformation implementation. 965 #pragma mark - BrowserViewInformation implementation.
964 966
965 - (void)haltAllTabs { 967 - (void)haltAllTabs {
(...skipping 1658 matching lines...) Expand 10 before | Expand all | Expand 10 after
2624 }; 2626 };
2625 2627
2626 callbackCounter->IncrementCount(); 2628 callbackCounter->IncrementCount();
2627 [self removeBrowsingDataFromBrowserState:_mainBrowserState 2629 [self removeBrowsingDataFromBrowserState:_mainBrowserState
2628 mask:removeAllMask 2630 mask:removeAllMask
2629 timePeriod:browsing_data::TimePeriod::ALL_TIME 2631 timePeriod:browsing_data::TimePeriod::ALL_TIME
2630 completionHandler:decrementCallbackCounterCount]; 2632 completionHandler:decrementCallbackCounterCount];
2631 } 2633 }
2632 2634
2633 @end 2635 @end
OLDNEW
« no previous file with comments | « no previous file | ios/chrome/app/spotlight/topsites_spotlight_manager.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698