Fix off-by-one in ALSA control name determination.

Fix off-by-one in ALSA control name determination.

Previously, given a device_id "plug:foo" alsa_util.cc would try to open
the control named ":foo". It will now open "foo".

This is safe because at this point we know we have already found a ':'
at pos1.

BUG=internal 35197382
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2883313004
Cr-Commit-Position: refs/heads/master@{#472218}
Committed: https://chromium.googlesource.com/chromium/src/+/14744bc1d40b22390430584005ca10495331701d

[jyw, 2017-05-16 18:01:37]

Description was changed from

==========
Fix off-by-one in ALSA control name determination.

Previously, given a device_id "plug:foo" alsa_util.cc would try to open
the control named ":foo". It will now open "foo".

This is safe because at this point we know we have already found a ':'
at pos1.

BUG=internal 35197382
TEST=manual
==========

to

==========
Fix off-by-one in ALSA control name determination.

Previously, given a device_id "plug:foo" alsa_util.cc would try to open
the control named ":foo". It will now open "foo".

This is safe because at this point we know we have already found a ':'
at pos1.

BUG=internal 35197382
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jyw1, 2017-05-16 18:43:49]

The CQ bit was checked by jyw@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 18:44:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jyw1, 2017-05-16 18:56:42]

jyw@google.com changed reviewers:
+ dalecurtis@chromium.org, watk@chromium.org

[alokp, 2017-05-16 18:56:51]

alokp@chromium.org changed reviewers:
+ alokp@chromium.org, tommi@chromium.org
- dalecurtis@chromium.org, jyw@google.com, watk@chromium.org

[alokp, 2017-05-16 18:56:51]

Tommi: Could you PTAL. Dale is OOO.

[DaleCurtis, 2017-05-16 19:06:01]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2017-05-16 19:06:02]

lgtm, caveat that this means you'll get an empty string back now versus before a
':' if there's some issue with the name.

[commit-bot: I haz the power, 2017-05-16 20:54:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 20:54:38]

Dry run: This issue passed the CQ dry run.

[jyw1, 2017-05-16 20:59:09]

On 2017/05/16 19:06:02, DaleCurtis_OOO_May_5_To_May23 wrote:
> lgtm, caveat that this means you'll get an empty string back now versus before
a
> ':' if there's some issue with the name.

That's fine with me.

[jyw1, 2017-05-16 20:59:14]

The CQ bit was checked by jyw@google.com

[commit-bot: I haz the power, 2017-05-16 21:00:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 21:10:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494968354057800, "parent_rev":
"f5ac1cf6941b6b5bbdfaabf6287e5a826c4b602d", "commit_rev":
"14744bc1d40b22390430584005ca10495331701d"}

[commit-bot: I haz the power, 2017-05-16 21:11:08]

Description was changed from

==========
Fix off-by-one in ALSA control name determination.

Previously, given a device_id "plug:foo" alsa_util.cc would try to open
the control named ":foo". It will now open "foo".

This is safe because at this point we know we have already found a ':'
at pos1.

BUG=internal 35197382
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix off-by-one in ALSA control name determination.

Previously, given a device_id "plug:foo" alsa_util.cc would try to open
the control named ":foo". It will now open "foo".

This is safe because at this point we know we have already found a ':'
at pos1.

BUG=internal 35197382
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2883313004
Cr-Commit-Position: refs/heads/master@{#472218}
Committed:
https://chromium.googlesource.com/chromium/src/+/14744bc1d40b22390430584005ca...
==========

[commit-bot: I haz the power, 2017-05-16 21:11:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14744bc1d40b22390430584005ca...