Map visual rects of descendants under LayoutSVGHiddenContainer to the temporary root

Map visual rects of descendants under LayoutSVGHiddenContainer to the temporary root

BUG=722761
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
R=chrishtr@chromium.org

Review-Url: https://codereview.chromium.org/2883263003 .
Cr-Commit-Position: refs/heads/master@{#472551}
Committed: https://chromium.googlesource.com/chromium/src/+/0357ef87967c4633b4d6c39de8362ed03831ef90

[Xianzhu, 2017-05-16 23:42:23]

Description was changed from

==========
Map visual rects of descendants under LayoutSVGHiddenContainer to the temporary
root

BUG=722761
==========

to

==========
Map visual rects of descendants under LayoutSVGHiddenContainer to the temporary
root

BUG=722761
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-05-16 23:43:01]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[Xianzhu, 2017-05-16 23:43:01]

This is the correct CL. Ptal.

[chrishtr, 2017-05-17 00:42:41]

https://codereview.chromium.org/2883263003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintInvalidator.cpp (right):

https://codereview.chromium.org/2883263003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:98: bool
map_to_backing =
Is this mapping necessary for testing, or for repaint-after-layout checks?
If so, in what scenario?

[Xianzhu, 2017-05-17 00:49:45]

https://codereview.chromium.org/2883263003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintInvalidator.cpp (right):

https://codereview.chromium.org/2883263003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:98: bool
map_to_backing =
On 2017/05/17 00:42:41, chrishtr wrote:
> Is this mapping necessary for testing, or for repaint-after-layout checks?
> If so, in what scenario?

It's for repaint-after-layout checks to invalidate changed DisplayItemClients
under the hidden container, so that they will be updated when the resource is
recorded.

[chrishtr, 2017-05-17 01:08:14]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-05-17 01:08:14]

lgtm

[commit-bot: I haz the power, 2017-05-17 01:10:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 02:50:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 02:50:29]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-05-17 03:19:52]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-05-17 03:19:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2883263003/#ps20001
(title: "Remove DCHECK(map_to_backing) in slow path (it does happen, and mapping
to paint_invalidation_conta…")

[commit-bot: I haz the power, 2017-05-17 03:21:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 04:46:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 04:46:08]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-05-17 15:49:59]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-05-17 15:50:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 17:52:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 17:52:55]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-05-17 18:04:29]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-05-17 18:06:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-05-17 20:28:04]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-05-17 20:28:49]

Description was changed from

==========
Map visual rects of descendants under LayoutSVGHiddenContainer to the temporary
root

BUG=722761
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Map visual rects of descendants under LayoutSVGHiddenContainer to the temporary
root

BUG=722761
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
R=chrishtr@chromium.org

Review-Url: https://codereview.chromium.org/2883263003 .
Cr-Commit-Position: refs/heads/master@{#472551}
Committed:
https://chromium.googlesource.com/chromium/src/+/0357ef87967c4633b4d6c39de836...
==========

[Xianzhu, 2017-05-17 20:28:50]

Committed patchset #2 (id:20001) manually as
0357ef87967c4633b4d6c39de8362ed03831ef90 (presubmit successful).