Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2883233002: Revert of Fix main frame detection in loading metrics. (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Fix main frame detection in loading metrics. (patchset #7 id:120001 of https://codereview.chromium.org/2862103002/ ) Reason for revert: Test failures on Mac: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.12%20Tests/builds/531 Original issue's description: > Fix main frame detection in loading metrics. > > The existing way to detect the main frame produces false positives > as described in https://crbug.com/692112#c10. > > This patch uses a recently added trace event that marks the > main frame (category='loading', title='markAsMainFrame') to > make main frame detection accurate. > > All detection logic is encapsulated in MainFrameHelper class. > > BUG=chromium:692112 > > Review-Url: https://codereview.chromium.org/2862103002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9e7bc18ce70595be32d8534b4309aff83ac78434 TBR=benjhayden@chromium.org,dproy@chromium.org,lingyun.cai@intel.com,nednguyen@google.com,tdresser@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:692112 Review-Url: https://codereview.chromium.org/2883233002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/10606a997dbd497af4be92af2ef867f687821f23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -458 lines) Patch
M tracing/tracing/extras/chrome/estimated_input_latency_test.html View 3 chunks +4 lines, -10 lines 0 comments Download
M tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html View 1 chunk +0 lines, -7 lines 0 comments Download
M tracing/tracing/metrics/system_health/loading_metric.html View 14 chunks +62 lines, -180 lines 0 comments Download
M tracing/tracing/metrics/system_health/loading_metric_test.html View 12 chunks +0 lines, -247 lines 0 comments Download
M tracing/tracing/metrics/system_health/power_metric_test.html View 1 chunk +0 lines, -7 lines 0 comments Download
M tracing/tracing/metrics/v8/runtime_stats_metric_test.html View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ulan
Created Revert of Fix main frame detection in loading metrics.
3 years, 7 months ago (2017-05-16 08:36:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883233002/1
3 years, 7 months ago (2017-05-16 08:36:22 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 08:36:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698