The CQ bit was checked by ulan@chromium.org
Created Revert of Fix main frame detection in loading metrics.
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1494923771342470, "parent_rev": "8c5582059a983d4a2e74afc72d15ad78fe1acfb6", "commit_rev": "10606a997dbd497af4be92af2ef867f687821f23"}
Description was changed from ========== Revert of Fix main frame detection in loading metrics. (patchset #7 id:120001 of https://codereview.chromium.org/2862103002/ ) Reason for revert: Test failures on Mac: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.12%20Tests... Original issue's description: > Fix main frame detection in loading metrics. > > The existing way to detect the main frame produces false positives > as described in https://crbug.com/692112#c10. > > This patch uses a recently added trace event that marks the > main frame (category='loading', title='markAsMainFrame') to > make main frame detection accurate. > > All detection logic is encapsulated in MainFrameHelper class. > > BUG=chromium:692112 > > Review-Url: https://codereview.chromium.org/2862103002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... TBR=benjhayden@chromium.org,dproy@chromium.org,lingyun.cai@intel.com,nednguye... # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:692112 ========== to ========== Revert of Fix main frame detection in loading metrics. (patchset #7 id:120001 of https://codereview.chromium.org/2862103002/ ) Reason for revert: Test failures on Mac: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.12%20Tests... Original issue's description: > Fix main frame detection in loading metrics. > > The existing way to detect the main frame produces false positives > as described in https://crbug.com/692112#c10. > > This patch uses a recently added trace event that marks the > main frame (category='loading', title='markAsMainFrame') to > make main frame detection accurate. > > All detection logic is encapsulated in MainFrameHelper class. > > BUG=chromium:692112 > > Review-Url: https://codereview.chromium.org/2862103002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... TBR=benjhayden@chromium.org,dproy@chromium.org,lingyun.cai@intel.com,nednguye... # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:692112 Review-Url: https://codereview.chromium.org/2883233002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu...