Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2883173002: Remove erroneous comment for net::EscapePath(). (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org, Peter Kasting
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove erroneous comment for net::EscapePath(). Review-Url: https://codereview.chromium.org/2883173002 Cr-Commit-Position: refs/heads/master@{#472025} Committed: https://chromium.googlesource.com/chromium/src/+/35750723170c212e5b588861b1b39abe7c46c253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M net/base/escape.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
In https://chromiumcodereview.appspot.com/10444117, the API changed between patch set 1 and 2, but the comment didn't ...
3 years, 7 months ago (2017-05-15 23:44:45 UTC) #4
mattm
lgtm
3 years, 7 months ago (2017-05-15 23:49:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883173002/1
3 years, 7 months ago (2017-05-16 05:57:22 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 06:03:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/35750723170c212e5b588861b1b3...

Powered by Google App Engine
This is Rietveld 408576698