Timeline: do not start timeline on regular page reloads

Timeline: do not start timeline on regular page reloads

This disables automatic timeline recording on page reload.
To record a reload users now should either use reload button on Timelin
panel or use a dedicated shortcut (Ctrl+Shift+E).

BUG=708099
Review-Url: https://codereview.chromium.org/2883143003
Cr-Commit-Position: refs/heads/master@{#472193}
Committed: https://chromium.googlesource.com/chromium/src/+/68d14c041a06c7a9acca3ec3113ce36324371d13

[caseq, 2017-05-15 22:38:03]

caseq@chromium.org changed reviewers:
+ alph@chromium.org, paulirish@chromium.org

[alph, 2017-05-15 23:56:46]

lgtm

https://codereview.chromium.org/2883143003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
(right):

https://codereview.chromium.org/2883143003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:810:
setTimeout(stopRecordingOnReload.bind(this, this._controller),
this._millisecondsToRecordAfterLoadEvent);
await sleep(...)

[caseq, 2017-05-15 23:57:15]

The CQ bit was checked by caseq@chromium.org

[paul.irish, 2017-05-15 23:58:20]

paul.irish@gmail.com changed reviewers:
+ paul.irish@gmail.com

[paul.irish, 2017-05-15 23:58:20]

The landing mentions the new shortcut, yes?
Lgtm if so.

Also is the shortcut new?

[commit-bot: I haz the power, 2017-05-15 23:58:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caseq, 2017-05-16 00:06:03]

On 2017/05/15 23:58:20, paul.irish wrote:
> The landing mentions the new shortcut, yes?
> Lgtm if so.
> 
> Also is the shortcut new?

Yes on both counts, Ctrl+Shift+E as suggested in the bug.

[commit-bot: I haz the power, 2017-05-16 01:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 01:54:27]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[caseq, 2017-05-16 17:26:51]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2017-05-16 17:27:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 19:42:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494955611526730,
"parent_rev": "1f92cfbdedaecb97e8a87773deb32f98c6997351", "commit_rev":
"68d14c041a06c7a9acca3ec3113ce36324371d13"}

[commit-bot: I haz the power, 2017-05-16 19:42:47]

Description was changed from

==========
Timeline: do not start timeline on regular page reloads

This disables automatic timeline recording on page reload.
To record a reload users now should either use reload button on Timelin
panel or use a dedicated shortcut (Ctrl+Shift+E).

BUG=708099
==========

to

==========
Timeline: do not start timeline on regular page reloads

This disables automatic timeline recording on page reload.
To record a reload users now should either use reload button on Timelin
panel or use a dedicated shortcut (Ctrl+Shift+E).

BUG=708099

Review-Url: https://codereview.chromium.org/2883143003
Cr-Commit-Position: refs/heads/master@{#472193}
Committed:
https://chromium.googlesource.com/chromium/src/+/68d14c041a06c7a9acca3ec3113c...
==========

[commit-bot: I haz the power, 2017-05-16 19:42:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/68d14c041a06c7a9acca3ec3113c...