Reorder URLRequestContextStorage members.

Reorder URLRequestContextStorage members.

In particular, ProxyService depends on NetworkDelegate and
ProxyDelegate, so delete the ProxyService first.

BUG=715695
Review-Url: https://codereview.chromium.org/2883143002
Cr-Commit-Position: refs/heads/master@{#472009}
Committed: https://chromium.googlesource.com/chromium/src/+/f13aaab4c0c1c0c03fa8f3c2d62291f1a2c12e68

[mmenke, 2017-05-15 21:06:23]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 21:07:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-05-15 21:07:47]

Description was changed from

==========
Reorder URLRequestContextStorage members.

In particular, ProxyService depends on NetworkDelegate and
ProxyDelegate, so delete the ProxyService first.

BUG=none
==========

to

==========
Reorder URLRequestContextStorage members.

In particular, ProxyService depends on NetworkDelegate and
ProxyDelegate, so delete the ProxyService first.

BUG=715695
==========

[mmenke, 2017-05-15 21:09:13]

mmenke@chromium.org changed reviewers:
+ eroman@chromium.org

[mmenke, 2017-05-15 21:09:14]

This was causing a crash in a CL where I switched to using
URLRequestContextStorage for the IOThread's RequestContext - explicitly shutting
down the IOThread's ProxyService fixes it, too, and I'll do that as well, but
seems like the order here should reflect dependencies as well.

[eroman, 2017-05-15 21:13:50]

Is this covered by existing unit-tests?

[eroman, 2017-05-15 21:13:59]

lgtm

[mmenke, 2017-05-15 21:20:41]

On 2017/05/15 21:13:50, eroman wrote:
> Is this covered by existing unit-tests?

No - and I'm not sure how well it can be.  I think you only run into issuers
during teardown if the NetworkDelegate is being shared with another
URLRequestContext that has not yet been shut down, which isn't something that's
really sane to do with this class, anyways (Yes, I'm doing it now, but doing to
send out a CL to change that tomorrow - was probably wrong not to do that
first).

[mmenke, 2017-05-15 21:20:48]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-05-15 21:21:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 23:16:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 23:16:39]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mmenke, 2017-05-16 00:55:09]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-05-16 00:56:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 03:56:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494896109115570,
"parent_rev": "4cd62becec2902f99720eb0c5b4602eecfbd6ef1", "commit_rev":
"f13aaab4c0c1c0c03fa8f3c2d62291f1a2c12e68"}

[commit-bot: I haz the power, 2017-05-16 03:57:09]

Description was changed from

==========
Reorder URLRequestContextStorage members.

In particular, ProxyService depends on NetworkDelegate and
ProxyDelegate, so delete the ProxyService first.

BUG=715695
==========

to

==========
Reorder URLRequestContextStorage members.

In particular, ProxyService depends on NetworkDelegate and
ProxyDelegate, so delete the ProxyService first.

BUG=715695

Review-Url: https://codereview.chromium.org/2883143002
Cr-Commit-Position: refs/heads/master@{#472009}
Committed:
https://chromium.googlesource.com/chromium/src/+/f13aaab4c0c1c0c03fa8f3c2d622...
==========

[commit-bot: I haz the power, 2017-05-16 03:57:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f13aaab4c0c1c0c03fa8f3c2d622...