Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 288313009: Remove unused (by clients) SkUnitMapper (Closed)

Created:
6 years, 7 months ago by reed1
Modified:
6 years, 7 months ago
Reviewers:
f(malita)
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove unused (by clients) SkUnitMapper This reverts commit 874423a81b5bc2541c7397e6ab00d5e7c9fdaf98. TBR=scroggo Committed: http://code.google.com/p/skia/source/detail?r=14842

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -792 lines) Patch
M bench/GradientBench.cpp View 8 chunks +18 lines, -29 lines 0 comments Download
M expectations/gm/ignored-tests.txt View 1 chunk +13 lines, -1 line 0 comments Download
M experimental/SkiaExamples/HelloSkiaExample.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M experimental/webtry/templates/template.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gm/alphagradients.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/colortype.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/convexpolyclip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/drawbitmaprect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradientDirtyLaundry.cpp View 2 chunks +9 lines, -14 lines 0 comments Download
M gm/gradient_matrix.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/gradients.cpp View 7 chunks +17 lines, -24 lines 0 comments Download
M gm/gradients_2pt_conical.cpp View 20 chunks +37 lines, -65 lines 0 comments Download
M gm/gradients_no_texture.cpp View 4 chunks +13 lines, -20 lines 0 comments Download
M gm/shaderbounds.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadertext.cpp View 5 chunks +13 lines, -27 lines 0 comments Download
M gm/shadertext2.cpp View 2 chunks +1 line, -8 lines 0 comments Download
M gm/shadertext3.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M gm/tilemodes.cpp View 2 chunks +1 line, -9 lines 0 comments Download
M gm/tilemodes_scaled.cpp View 2 chunks +1 line, -9 lines 0 comments Download
M gyp/SampleApp.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/public_headers.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +0 lines, -1 line 1 comment Download
M gyp/utils.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M include/core/SkFlattenable.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPicture.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkReadBuffer.h View 3 chunks +6 lines, -2 lines 0 comments Download
D include/core/SkUnitMapper.h View 1 chunk +0 lines, -37 lines 0 comments Download
M include/effects/SkGradientShader.h View 6 chunks +30 lines, -67 lines 0 comments Download
M samplecode/SampleAll.cpp View 3 chunks +2 lines, -7 lines 0 comments Download
M samplecode/SampleGradients.cpp View 4 chunks +14 lines, -21 lines 0 comments Download
M samplecode/SampleLayers.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SamplePatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleShaderText.cpp View 5 chunks +13 lines, -27 lines 0 comments Download
M samplecode/SampleSlides.cpp View 4 chunks +11 lines, -18 lines 0 comments Download
M samplecode/SampleTiling.cpp View 2 chunks +1 line, -9 lines 0 comments Download
D samplecode/SampleUnitMapper.cpp View 1 chunk +0 lines, -172 lines 0 comments Download
M samplecode/SampleVertices.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawGradient.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/animator/SkDrawGradient.cpp View 5 chunks +3 lines, -49 lines 0 comments Download
M src/core/SkReadBuffer.cpp View 1 chunk +22 lines, -0 lines 0 comments Download
M src/core/SkValidatingReadBuffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkValidatingReadBuffer.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 21 chunks +13 lines, -74 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 3 chunks +0 lines, -3 lines 0 comments Download
D src/utils/SkUnitMappers.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
reed1
The CQ bit was checked by reed@google.com
6 years, 7 months ago (2014-05-22 12:21:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/288313009/1
6 years, 7 months ago (2014-05-22 12:22:14 UTC) #2
commit-bot: I haz the power
Change committed as 14842
6 years, 7 months ago (2014-05-22 12:27:53 UTC) #3
f(malita)
https://codereview.chromium.org/288313009/diff/1/gyp/skia_for_chromium_defines.gypi File gyp/skia_for_chromium_defines.gypi (left): https://codereview.chromium.org/288313009/diff/1/gyp/skia_for_chromium_defines.gypi#oldcode19 gyp/skia_for_chromium_defines.gypi:19: 'SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX', Was this intentional? I see Blink's GraphicsContextRecorder is ...
6 years, 7 months ago (2014-05-22 14:01:16 UTC) #4
reed1
On 2014/05/22 14:01:16, Florin Malita wrote: > https://codereview.chromium.org/288313009/diff/1/gyp/skia_for_chromium_defines.gypi > File gyp/skia_for_chromium_defines.gypi (left): > > https://codereview.chromium.org/288313009/diff/1/gyp/skia_for_chromium_defines.gypi#oldcode19 ...
6 years, 7 months ago (2014-05-22 14:02:53 UTC) #5
f(malita)
6 years, 7 months ago (2014-05-22 14:04:20 UTC) #6
Message was sent while issue was closed. 
On 2014/05/22 14:02:53, reed1 wrote:
> On 2014/05/22 14:01:16, Florin Malita wrote:
> >
>
https://codereview.chromium.org/288313009/diff/1/gyp/skia_for_chromium_define...
> > File gyp/skia_for_chromium_defines.gypi (left):
> > 
> >
>
https://codereview.chromium.org/288313009/diff/1/gyp/skia_for_chromium_define...
> > gyp/skia_for_chromium_defines.gypi:19:
'SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX',
> > Was this intentional? I see Blink's GraphicsContextRecorder is still calling
> > hasLocalMatrix() and now ToT builds are failing.
> 
> Doh. I (thought I) built all locally, and it passed. Don't know how I missed
> that.
> 
> I'll edit the gypi in a moment to see if that fixes it.

I think that's the only caller left, I can patch Blink too.

Powered by Google App Engine
This is Rietveld 408576698