Add page.CanRunOnBrowser. Add WebGL check for tough_webgl_cases pages

Add page.CanRunOnBrowser. Add WebGL check for tough_webgl_cases pages

BUG=373812
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272620

[dtu, 2014-05-17 00:53:33]

https://codereview.chromium.org/288313005/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/page_runner.py (right):

https://codereview.chromium.org/288313005/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_runner.py:259:
results_for_current_run.StopTest(page)
StopTest just records the end of the test in the results, it doesn't actually
stop the test execution. You'll need to return here.

[nednguyen, 2014-05-17 02:13:34]

On 2014/05/17 00:53:33, dtu wrote:
>
https://codereview.chromium.org/288313005/diff/1/tools/telemetry/telemetry/pa...
> File tools/telemetry/telemetry/page/page_runner.py (right):
> 
>
https://codereview.chromium.org/288313005/diff/1/tools/telemetry/telemetry/pa...
> tools/telemetry/telemetry/page/page_runner.py:259:
> results_for_current_run.StopTest(page)
> StopTest just records the end of the test in the results, it doesn't actually
> stop the test execution. You'll need to return here.

Actually now I realize that this is quite dangerous to expose the actual browser
object. I will wrap browser with some class.

[nduca, 2014-05-22 00:06:21]

lgtm

[nednguyen, 2014-05-22 00:11:35]

On 2014/05/22 00:06:21, nduca wrote:
> lgtm

Tony, please let me know if you are happy with this. You once worried about
page_set taking platform specific branches:
https://code.google.com/p/chromium/issues/detail?id=239179#c1

[tonyg, 2014-05-23 00:54:27]

lgtm

PageSet level guards seem fine. Page level would be more concerning.

[nednguyen, 2014-05-23 01:41:41]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-05-23 01:43:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nednguyen@google.com/288313005/80001

[commit-bot: I haz the power, 2014-05-23 05:18:57]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-23 05:23:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-23 05:23:11]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[nednguyen, 2014-05-23 15:23:15]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-05-23 15:24:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nednguyen@google.com/288313005/80001

[commit-bot: I haz the power, 2014-05-23 15:31:25]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-23 15:36:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-23 15:36:35]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[nednguyen, 2014-05-23 15:53:56]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-05-23 15:56:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nednguyen@google.com/288313005/120001

[commit-bot: I haz the power, 2014-05-23 20:03:23]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-23 22:45:31]

Change committed as 272620