Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 288313005: Add page.CanRunOnBrowser. Add WebGL check for tough_webgl_cases pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix rebase mistakes Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page.py ('k') | tools/telemetry/telemetry/page/page_runner_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index 6e8ec2a99bd43f63cb2f845a384d749590903ea7..4d684c6ccff055b8f1b3b2f2ba32e516cc35d2fc 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -14,6 +14,7 @@ import time
from telemetry import decorators
from telemetry.core import browser_finder
+from telemetry.core import browser_info
from telemetry.core import exceptions
from telemetry.core import util
from telemetry.core import wpr_modes
@@ -251,6 +252,11 @@ def _PrepareAndRunPage(test, page_set, expectations, finder_options,
# options for just the current page before starting the browser.
state.StartBrowserIfNeeded(test, page_set, page, possible_browser,
credentials_path, page.archive_path)
+ if not page.CanRunOnBrowser(browser_info.BrowserInfo(state.browser)):
+ logging.info('Skip test for page %s because browser is not supported.'
+ % page.url)
+ results_for_current_run.StopTest(page)
+ return results
expectation = expectations.GetExpectationForPage(state.browser, page)
« no previous file with comments | « tools/telemetry/telemetry/page/page.py ('k') | tools/telemetry/telemetry/page/page_runner_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698