Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2883083003:
Prune ComputeVisibleSelectionInDOMTreeDeprecated from WebFrameWidgetImpl::SelectionBounds (Closed)
DescriptionPrune ComputeVisibleSelectionInDOMTreeDeprecated from WebFrameWidgetImpl::SelectionBounds
This patch prunes a call site of the deprecated function to improve code
health. The change is safe because it is equivalent to hoisting the layout
update from the deprecated function.
BUG=698633
TEST=n/a; no behavioral changes
Review-Url: https://codereview.chromium.org/2883083003
Cr-Commit-Position: refs/heads/master@{#472190}
Committed: https://chromium.googlesource.com/chromium/src/+/0c1b47cd5f45d567d8b1ea929ab2efd413045862
Patch Set 1 #
Messages
Total messages: 25 (17 generated)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from WebFrameWidgetImpl::SelectionBounds BUG= ========== to ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from WebFrameWidgetImpl::SelectionBounds This patch prunes a call site of the deprecated function to improve code health. The change is safe because it is equivalent to hoisting the layout update from the deprecated function. BUG=698633 TEST=n/a; no behavioral changes ==========
xiaochengh@chromium.org changed reviewers: + tkent@chromium.org
PTAL.
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xiaochengh@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xiaochengh@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xiaochengh@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494955778795680, "parent_rev":
"4879277aedd93a1792b348e0ab391baa2d77714e", "commit_rev":
"0c1b47cd5f45d567d8b1ea929ab2efd413045862"}
Message was sent while issue was closed.
Description was changed from ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from WebFrameWidgetImpl::SelectionBounds This patch prunes a call site of the deprecated function to improve code health. The change is safe because it is equivalent to hoisting the layout update from the deprecated function. BUG=698633 TEST=n/a; no behavioral changes ========== to ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from WebFrameWidgetImpl::SelectionBounds This patch prunes a call site of the deprecated function to improve code health. The change is safe because it is equivalent to hoisting the layout update from the deprecated function. BUG=698633 TEST=n/a; no behavioral changes Review-Url: https://codereview.chromium.org/2883083003 Cr-Commit-Position: refs/heads/master@{#472190} Committed: https://chromium.googlesource.com/chromium/src/+/0c1b47cd5f45d567d8b1ea929ab2... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0c1b47cd5f45d567d8b1ea929ab2... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
