Propagate inert state to OOPIFs when a modal dialog is active

third_party/WebKit/Source/core/html/HTMLDialogElement.cpp

Index: third_party/WebKit/Source/core/html/HTMLDialogElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp b/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp
index f5af85eb93c424bada4d34ff2055adb825e80561..0f0abaf3a235b2f274e7b5abab4b38d7d5d50456 100644
--- a/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp
@@ -81,6 +81,13 @@ static void SetFocusForDialog(HTMLDialogElement* dialog) {
 }
 
 static void InertSubtreesChanged(Document& document) {
+  // TODO(kenrb): Am I correct in thinking that this will never get called on
+  // and element that is in a frame that is already inert? If not, we

[dmazzoni, 2017/05/18 15:47:06]

I don't see how we can know that. A page can always try to call "open" on a
dialog, right?

I think we need to handle that case.

[kenrb, 2017/05/19 17:46:28]

Done.

+  // need to get the embedding frame's inert value and use that instead of
+  // false.
+  if (document.GetFrame())
+    document.GetFrame()->SetIsInert(false);

[aboxhall, 2017/05/18 04:47:27]

When does SetIsInert(true) get called?

Also, you might want to add a case to
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/html/dial...
to ensure that frames *outside* the dialog (incl. OOPIFs) are correctly made
inert, while frames *inside* the dialog are *not* made inert.

[kenrb, 2017/05/18 12:21:49]

See LocalFrame::SetIsInert(). I should probably add some comments on that
method, but it works such that if you call it with true then it propagates the
inert flag down through all of its descendant frames, and if you call it with
false then it has each of its descendant frames check for inertness via
Node::IsInert().
I can do that. Unfortunately testing OOPIFs in layout tests is a bit more
complicated, since they have to be in LayoutTests/http/tests/ in order to load
frames in different origins. I'll see if I can get something working for that.

+
   // When a modal dialog opens or closes, nodes all over the accessibility
   // tree can change inertness which means they must be added or removed from
   // the tree. The most foolproof way is to clear the entire tree and rebuild
@@ -182,7 +189,7 @@ void HTMLDialogElement::showModal(ExceptionState& exception_state) {
 void HTMLDialogElement::RemovedFrom(ContainerNode* insertion_point) {
   HTMLElement::RemovedFrom(insertion_point);
   SetNotCentered();
-  // FIXME: We should call inertSubtreesChanged() here.
+  InertSubtreesChanged(GetDocument());
 }
 
 void HTMLDialogElement::SetCentered(LayoutUnit centered_position) {