Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2883033003: Propagate inert state to OOPIFs when a modal dialog is active (Closed)
Patch Set: Fix test crash Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrame.h
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h
index 47e9082e168a5930ac9548c9bdc6f8c03a8ef10c..9c7d5ab16af60fa93b133c66b508eb990755e828 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.h
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h
@@ -237,6 +237,11 @@ class CORE_EXPORT LocalFrame final : public Frame,
std::unique_ptr<WebURLLoader> CreateURLLoader();
+ // This sets the is_inert_ flag and also recurses through this frame's
+ // subtree, updating the inert bit on all descendant frames.
+ void SetIsInert(bool inert);
+ bool IsInert() const { return is_inert_; }
+
using FrameInitCallback = void (*)(LocalFrame*);
// Allows for the registration of a callback that is invoked whenever a new
// LocalFrame is initialized. Callbacks are executed in the order that they
@@ -261,6 +266,8 @@ class CORE_EXPORT LocalFrame final : public Frame,
void EnableNavigation() { --navigation_disable_count_; }
void DisableNavigation() { ++navigation_disable_count_; }
+ void PropagateInertToChildFrames();
+
std::unique_ptr<WebFrameScheduler> frame_scheduler_;
mutable FrameLoader loader_;
@@ -287,6 +294,8 @@ class CORE_EXPORT LocalFrame final : public Frame,
bool in_view_source_mode_;
+ bool is_inert_;
+
Member<CoreProbeSink> probe_sink_;
Member<PerformanceMonitor> performance_monitor_;

Powered by Google App Engine
This is Rietveld 408576698