third_party/WebKit/Source/core/dom/Node.cpp - Issue 2883033003: Propagate inert state to OOPIFs when a modal dialog is active

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2883033003: Propagate inert state to OOPIFs when a modal dialog is active (Closed)

Patch Set: Fix test crash Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Node.cpp

diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp

index 2c1b5bee29fb8df519818bd1fb51beae183a9303..080a0c84bcce907a5323356cb38ce37b9bc4661b 100644

--- a/third_party/WebKit/Source/core/dom/Node.cpp

+++ b/third_party/WebKit/Source/core/dom/Node.cpp

@@ -851,7 +851,7 @@ bool Node::IsInert() const {

(!CanParticipateInFlatTree() ||

!FlatTreeTraversal::ContainsIncludingPseudoElement(*dialog, *this)))

return true;

- return GetDocument().LocalOwner() && GetDocument().LocalOwner()->IsInert();

+ return GetDocument().GetFrame() && GetDocument().GetFrame()->IsInert();

kenrb 2017/05/31 18:32:00 I had to keep the GetDocument().GetFrame() check,

}

unsigned Node::NodeIndex() const {