Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2882953002: Merge "INPUT/TEXTAREA elements: Fix incorrect selectionStart/selectionEnd values after blur." to M59 (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge "INPUT/TEXTAREA elements: Fix incorrect selectionStart/selectionEnd values after blur." to M59 We failed to update selectionStart/selectionEnd cache because TextControlElement::SelectionChanged() is not called in some cases after crrev.com/450370. After this CL, selection values are cached in webkitEditableContentChanged event handling code too. It is called on every DOM mutation in text control editor. BUG=714425 Review-Url: https://codereview.chromium.org/2878613002 Cr-Original-Commit-Position: refs/heads/master@{#471290} Review-Url: https://codereview.chromium.org/2882953002 . Cr-Commit-Position: refs/branch-heads/3071@{#549} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/e05011e0add858f12cb6f90cc534415870d9f7af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/forms/text-control-selection-after-blur.html View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/text/text-selection-after-type-change.html View 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/TextControlElement.cpp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
3 years, 7 months ago (2017-05-15 05:57:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e05011e0add858f12cb6f90cc534415870d9f7af.

Powered by Google App Engine
This is Rietveld 408576698