Remove dependency of DateTimeChooserImpl on ChromeClientImpl

third_party/WebKit/Source/core/loader/EmptyClients.cpp

Index: third_party/WebKit/Source/core/loader/EmptyClients.cpp
diff --git a/third_party/WebKit/Source/core/loader/EmptyClients.cpp b/third_party/WebKit/Source/core/loader/EmptyClients.cpp
index ec637fc65856cde53d60c4bda9b6d30d885b2e85..a205889fa5a77b56fb5d70fe8eaab20ee69d80f0 100644
--- a/third_party/WebKit/Source/core/loader/EmptyClients.cpp
+++ b/third_party/WebKit/Source/core/loader/EmptyClients.cpp
@@ -35,6 +35,7 @@
 #include "core/html/forms/ColorChooser.h"
 #include "core/html/forms/DateTimeChooser.h"
 #include "core/loader/DocumentLoader.h"
+#include "core/page/PagePopup.h"
 #include "platform/FileChooser.h"
 #include "platform/wtf/PtrUtil.h"
 #include "public/platform/Platform.h"
@@ -68,6 +69,13 @@ class EmptyPopupMenu : public PopupMenu {
   void DisconnectClient() override {}
 };
 
+class EmptyPagePopup : public PagePopup {
+ public:
+  AXObject* RootAXObject() override { return nullptr; }
+  void SetWindowRect(const IntRect&) override {}
+  void PostMessage(const String&) override {}
+};
+
 class EmptyFrameScheduler : public WebFrameScheduler {
  public:
   EmptyFrameScheduler() { DCHECK(IsMainThread()); }
@@ -98,6 +106,10 @@ PopupMenu* EmptyChromeClient::OpenPopupMenu(LocalFrame&, HTMLSelectElement&) {
   return new EmptyPopupMenu();
 }
 
+PagePopup* EmptyChromeClient::OpenPagePopup(PagePopupClient*) {
+  return new EmptyPagePopup();

[dcheng, 2017/05/15 04:04:51]

Can we just return nullptr here?

[sashab, 2017/05/15 05:23:32]

Good idea; done.

+}
+
 ColorChooser* EmptyChromeClient::OpenColorChooser(LocalFrame*,
                                                   ColorChooserClient*,
                                                   const Color&) {