Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2882903002: Make EOverflowWrap an enum class. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make EOverflowWrap an enum class. This patch makes EOverflowWrap an enum class for better type safety. BUG=684966 Review-Url: https://codereview.chromium.org/2882903002 Cr-Commit-Position: refs/heads/master@{#473084} Committed: https://chromium.googlesource.com/chromium/src/+/76d8ea110fdf384fcc37c37faab9a0a08f76160c

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 26 (22 generated)
shend
Hi Alan, PTAL
3 years, 7 months ago (2017-05-14 23:10:41 UTC) #5
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-15 04:22:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882903002/40001
3 years, 7 months ago (2017-05-19 04:13:19 UTC) #23
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 04:18:09 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/76d8ea110fdf384fcc37c37faab9...

Powered by Google App Engine
This is Rietveld 408576698