Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 2882883002: Fix a crash in Content Settings PolicyProvider::UpdateManagedDefaultSetting (Closed)

Created:
3 years, 7 months ago by raymes
Modified:
3 years, 7 months ago
Reviewers:
msramek
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash in Content Settings PolicyProvider::UpdateManagedDefaultSetting This crash was introduced in https://chromium.googlesource.com/chromium/src/+/26e1b6d4e1d7e27840055e3091520a43f59dde41 where we began checking if managed default settings were valid before loading them from the policy. However, not all content settings that can have managed defaults are registered on every platform. So we need to check that the setting is registered before checking if it is valid. BUG=721769 Review-Url: https://codereview.chromium.org/2882883002 Cr-Commit-Position: refs/heads/master@{#471974} Committed: https://chromium.googlesource.com/chromium/src/+/110620d3ae89e65a86ab1afd6149f6f6aa3c6d0c

Patch Set 1 #

Patch Set 2 : Fix a crash in Content Settings PolicyProvider::UpdateManagedDefaultSetting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M components/content_settings/core/browser/content_settings_policy_provider.cc View 1 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
raymes
3 years, 7 months ago (2017-05-14 22:28:33 UTC) #4
msramek
LGTM
3 years, 7 months ago (2017-05-15 08:42:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882883002/20001
3 years, 7 months ago (2017-05-15 22:37:20 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 01:36:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/110620d3ae89e65a86ab1afd6149...

Powered by Google App Engine
This is Rietveld 408576698