Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2882663002: Only resort to etl+1 when the full domain does not fit. (Closed)

Created:
3 years, 7 months ago by Miguel Garcia
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Only resort to etl+1 when the full domain does not fit. Mac native notifications have a somewhat constrained space for the origin Unlike chrome notifications it's harder to decide when to elide so instead we either show the full domain (if it fits in the very conservative limit we know works) or resort to etld+1 when it doesn't. BUG=717725 Review-Url: https://codereview.chromium.org/2861133003 Cr-Commit-Position: refs/heads/master@{#469953} (cherry picked from commit 8c70962f2be02fc57fc5bea12c7f7052605709ce) Review-Url: https://codereview.chromium.org/2882663002 . Cr-Commit-Position: refs/branch-heads/3071@{#527} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/e1dc2eaca46b9dd95beade54ea404652648e07fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -19 lines) Patch
M chrome/browser/notifications/notification_platform_bridge_mac.mm View 2 chunks +37 lines, -10 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm View 1 chunk +15 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Miguel Garcia
3 years, 7 months ago (2017-05-12 12:16:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e1dc2eaca46b9dd95beade54ea404652648e07fd.

Powered by Google App Engine
This is Rietveld 408576698