Use TaskScheduler instead of SequencedWorkerPool in platform_notification_context_impl.cc.

Use TaskScheduler instead of SequencedWorkerPool in platform_notification_context_impl.cc.

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

BUG=667892
R=miguelg@chromium.org

Review-Url: https://codereview.chromium.org/2882653003
Cr-Commit-Position: refs/heads/master@{#473472}
Committed: https://chromium.googlesource.com/chromium/src/+/6c40beb682f5974794ee29fbfd979041f73329fb

[fdoray, 2017-05-12 17:34:07]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2017-05-12 17:34:08]

Please take a look.

This CL was generated automatically.

The base::MayBlock() trait was specified for all call sites and the
base::TaskPriority::BACKGROUND trait was specified for all non-test call sites.
That may not be appropriate for your use case.

Please verify that appropriate traits were used
https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h
If everything looks good, lgtm and CQ this CL. Otherwise, tell us what's wrong.

Thanks.

- FAQ -

What if bots are red? Ignore this CL. A human will look at errors shortly.

What if the shutdown behavior is not set explicitly (no
base::TaskShutdownBehavior)?
If shutdown behavior is important for a task, it should be set explicitly.
It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or
SKIP_ON_SHUTDOWN. Note that the default shutdown behavior is BLOCK_SHUTDOWN in
SequencedWorkerPool and SKIP_ON_SHUTDOWN in TaskScheduler.

What if the task priority is not set explicitly (no base::TaskPriority)?
When there is no explicit priority, the priority is inherited from the
calling context (e.g. a task posted from a BACKGROUND task without an
explicit priority will have a BACKGROUND priority).

[commit-bot: I haz the power, 2017-05-12 17:34:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 18:53:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 18:53:09]

Dry run: This issue passed the CQ dry run.

[fdoray, 2017-05-17 20:39:24]

On 2017/05/12 17:34:08, fdoray wrote:
> Please take a look.
> 
> This CL was generated automatically.
> 
> The base::MayBlock() trait was specified for all call sites and the
> base::TaskPriority::BACKGROUND trait was specified for all non-test call
sites.
> That may not be appropriate for your use case.
> 
> Please verify that appropriate traits were used
> https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h
> If everything looks good, lgtm and CQ this CL. Otherwise, tell us what's
wrong.
> 
> Thanks.
> 
> - FAQ -
> 
> What if bots are red? Ignore this CL. A human will look at errors shortly.
> 
> What if the shutdown behavior is not set explicitly (no
> base::TaskShutdownBehavior)?
> If shutdown behavior is important for a task, it should be set explicitly.
> It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or
> SKIP_ON_SHUTDOWN. Note that the default shutdown behavior is BLOCK_SHUTDOWN in
> SequencedWorkerPool and SKIP_ON_SHUTDOWN in TaskScheduler.
> 
> What if the task priority is not set explicitly (no base::TaskPriority)?
> When there is no explicit priority, the priority is inherited from the
> calling context (e.g. a task posted from a BACKGROUND task without an
> explicit priority will have a BACKGROUND priority).

ping

[fdoray, 2017-05-19 20:09:04]

Description was changed from

==========
Use TaskScheduler instead of SequencedWorkerPool in
platform_notification_context_impl.cc.

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

BUG=667892
R=miguelg@chromium.org
==========

to

==========
Use TaskScheduler instead of SequencedWorkerPool in
platform_notification_context_impl.cc.

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

BUG=667892
R=miguelg@chromium.org
==========

[fdoray, 2017-05-19 20:09:04]

fdoray@chromium.org changed reviewers:
+ mkwst@chromium.org

[fdoray, 2017-05-19 20:09:25]

On 2017/05/17 20:39:24, fdoray wrote:
> On 2017/05/12 17:34:08, fdoray wrote:
> > Please take a look.
> > 
> > This CL was generated automatically.
> > 
> > The base::MayBlock() trait was specified for all call sites and the
> > base::TaskPriority::BACKGROUND trait was specified for all non-test call
> sites.
> > That may not be appropriate for your use case.
> > 
> > Please verify that appropriate traits were used
> > https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h
> > If everything looks good, lgtm and CQ this CL. Otherwise, tell us what's
> wrong.
> > 
> > Thanks.
> > 
> > - FAQ -
> > 
> > What if bots are red? Ignore this CL. A human will look at errors shortly.
> > 
> > What if the shutdown behavior is not set explicitly (no
> > base::TaskShutdownBehavior)?
> > If shutdown behavior is important for a task, it should be set explicitly.
> > It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN
or
> > SKIP_ON_SHUTDOWN. Note that the default shutdown behavior is BLOCK_SHUTDOWN
in
> > SequencedWorkerPool and SKIP_ON_SHUTDOWN in TaskScheduler.
> > 
> > What if the task priority is not set explicitly (no base::TaskPriority)?
> > When there is no explicit priority, the priority is inherited from the
> > calling context (e.g. a task posted from a BACKGROUND task without an
> > explicit priority will have a BACKGROUND priority).
> 
> ping

+mkwst@chromium.org (no reply from miguelg@chromium.org in one week)

[Peter Beverloo, 2017-05-19 21:41:10]

peter@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2017-05-19 21:41:10]

lgtm

[Mike West, 2017-05-20 20:49:47]

LGTM.

[fdoray, 2017-05-21 14:36:44]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-05-21 14:36:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-21 15:30:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495377404309040, "parent_rev":
"b6fe92147986d771ac55c5a017ad29937bfb080d", "commit_rev":
"6c40beb682f5974794ee29fbfd979041f73329fb"}

[commit-bot: I haz the power, 2017-05-21 15:30:43]

Description was changed from

==========
Use TaskScheduler instead of SequencedWorkerPool in
platform_notification_context_impl.cc.

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

BUG=667892
R=miguelg@chromium.org
==========

to

==========
Use TaskScheduler instead of SequencedWorkerPool in
platform_notification_context_impl.cc.

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

BUG=667892
R=miguelg@chromium.org

Review-Url: https://codereview.chromium.org/2882653003
Cr-Commit-Position: refs/heads/master@{#473472}
Committed:
https://chromium.googlesource.com/chromium/src/+/6c40beb682f5974794ee29fbfd97...
==========

[commit-bot: I haz the power, 2017-05-21 15:30:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c40beb682f5974794ee29fbfd97...