[DeviceService] Create end-to-end browsertest for BatteryMonitor

[DeviceService] Create end-to-end browsertest for BatteryMonitor

This CL is to confirm that in a real browser environment javascript
battery APIs(navigator.getBattery and its event listener) CAN eventually
succeed in connecting to Device Service to receive battery status change
notifications correctly.

BUG=717379
TEST=content_browsertests

Review-Url: https://codereview.chromium.org/2882633002
Cr-Commit-Position: refs/heads/master@{#473432}
Committed: https://chromium.googlesource.com/chromium/src/+/da7e1a15a2d765da4d26aa6e7855ced0ccecfb24

[leonhsl(Using Gerrit), 2017-05-12 09:00:23]

leon.han@intel.com changed reviewers:
+ blundell@chromium.org

[leonhsl(Using Gerrit), 2017-05-12 09:00:24]

Hi, Colin, PTAL, Thanks. This CL recovers old battery browser tests removed by
us due to eliminating hard dependency on battery impl from content.

# Can't trigger dry run now as the infra CL has been reverted. I'm investigating
around for that.

[leonhsl(Using Gerrit), 2017-05-12 09:01:23]

On 2017/05/12 09:00:24, leonhsl wrote:
> Hi, Colin, PTAL, Thanks. This CL recovers old battery browser tests removed by
> us due to eliminating hard dependency on battery impl from content.
> 
> # Can't trigger dry run now as the infra CL has been reverted. I'm
investigating
> around for that.

Locally confirmed these tests OK based on the infra CL.

[blundell, 2017-05-15 07:37:21]

lgtm with question

I assume that this is basically exactly the code that we previously removed,
with the only change being how we register the MockBatteryMonitor in the
browsertest?

[blundell, 2017-05-15 07:37:49]

(If not, tell me what the other differences are so that I can examine those
closely).

[leonhsl(Using Gerrit), 2017-05-15 07:57:06]

On 2017/05/15 07:37:21, blundell wrote:
> lgtm with question
> 
> I assume that this is basically exactly the code that we previously removed,
> with the only change being how we register the MockBatteryMonitor in the
> browsertest?

Yeah it is. And thanks a lot for review!

[leonhsl(Using Gerrit), 2017-05-16 09:53:25]

leon.han@intel.com changed reviewers:
+ jam@chromium.org

[leonhsl(Using Gerrit), 2017-05-16 09:53:25]

+John for OWNER review, Thanks!

[jam, 2017-05-17 01:20:45]

rs lgtm

[leonhsl(Using Gerrit), 2017-05-20 09:45:20]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2017-05-20 09:45:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 09:55:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-20 09:55:15]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[leonhsl(Using Gerrit), 2017-05-20 10:19:38]

The CQ bit was checked by leon.han@intel.com

[leonhsl(Using Gerrit), 2017-05-20 10:19:38]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/2882633002/#ps20001
(title: "Rebase only")

[commit-bot: I haz the power, 2017-05-20 10:19:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 10:58:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-20 10:58:53]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[leonhsl(Using Gerrit), 2017-05-20 11:30:25]

The CQ bit was checked by leon.han@intel.com

[leonhsl(Using Gerrit), 2017-05-20 11:30:25]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/2882633002/#ps40001
(title: "Close binding before destroying response callback")

[commit-bot: I haz the power, 2017-05-20 11:30:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 12:40:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495279825159740,
"parent_rev": "6b0a3020d8a5c87bedd003dccb80fed53ce8d3b3", "commit_rev":
"da7e1a15a2d765da4d26aa6e7855ced0ccecfb24"}

[commit-bot: I haz the power, 2017-05-20 12:41:13]

Description was changed from

==========
[DeviceService] Create end-to-end browsertest for BatteryMonitor

This CL is to confirm that in a real browser environment javascript
battery APIs(navigator.getBattery and its event listener) CAN eventually
succeed in connecting to Device Service to receive battery status change
notifications correctly.

BUG=717379
TEST=content_browsertests
==========

to

==========
[DeviceService] Create end-to-end browsertest for BatteryMonitor

This CL is to confirm that in a real browser environment javascript
battery APIs(navigator.getBattery and its event listener) CAN eventually
succeed in connecting to Device Service to receive battery status change
notifications correctly.

BUG=717379
TEST=content_browsertests

Review-Url: https://codereview.chromium.org/2882633002
Cr-Commit-Position: refs/heads/master@{#473432}
Committed:
https://chromium.googlesource.com/chromium/src/+/da7e1a15a2d765da4d26aa6e7855...
==========

[commit-bot: I haz the power, 2017-05-20 12:41:14]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/da7e1a15a2d765da4d26aa6e7855...