LayoutTests/fast/multicol/change-block-child-height.html - Issue 288263002: [New Multicolumn] Rebalance properly when child content changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/change-block-child-height.html

Issue 288263002: [New Multicolumn] Rebalance properly when child content changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: More cleanup; avoid bool arguments. Get rid of layout() override. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 if (window.internals)

	4 internals.settings.setRegionBasedColumnsEnabled(true);

	5 onload = function() {

	6 document.body.offsetTop; // trigger layout

	7 document.getElementById('elm').style.height = '0';

	8 }

	9 </script>

	10 <p>There should be a blue <em>square</em> below.</p>
	Julien - ping for review 2014/05/23 09:07:54 With no red? With no red? mstensho (USE GERRIT) 2014/05/23 11:46:09 Done. Show quoted text On 2014/05/23 09:07:54, Julien Chaffraix - CET wrote: > With no red? Done.
	11 <div style="-webkit-columns:3; columns:3; -webkit-column-gap:0; column-gap:0; wi dth:9em; line-height:9em; background:blue;">

	12 <br>

	13 <br>

	14 <div id="elm" style="height:10em; background:red;"></div>

	15 <br>

	16 </div>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/multicol/change-block-child-height-expected.html » ('j') | Source/core/rendering/RenderMultiColumnFlowThread.cpp » ('J')