Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2882613002: Revert of Enable overriding interface binders for any services running in current process. (Closed)

Created:
3 years, 7 months ago by henrika (OOO until Aug 14)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable overriding interface binders for any services running in current process. (patchset #5 id:130001 of https://codereview.chromium.org/2859343003/ ) Reason for revert: VibrationTest.Vibrate times out in browser_side_navigation_content_browsertests on Linux. See https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Tests__dbg__1_%2F63093%2F%2B%2Frecipes%2Fsteps%2Fbrowser_side_navigation_content_browsertests%2F0%2Fstdout Similar issues were found on many different platforms. Original issue's description: > Enable overriding interface binders for any services running in current process. > > This CL > - holds a 'service name <--> binder registry' map inside > service manager client library, at run time it acts as a global > variable in any process linking with service manager client library. > - lets ServiceContext::OnBindInterface() use the global map to > intercept requests before dispatching them to target Services, that > is to say, such interception may happen for any Services running in > current process. > - exposes {SetGlobalBinder,ClearGlobalBinders}ForTesting to set/clear > binders in the global map. > - adds a VibrationTest browser test to show the usage of the new infra > described above. > > BUG=717377, 717378 > TEST=content_browsertests > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2859343003 > Cr-Commit-Position: refs/heads/master@{#471216} > Committed: https://chromium.googlesource.com/chromium/src/+/d25e37df0f08a754fbc11041451a5ce7ca7d043d TBR=rockot@chromium.org,blundell@chromium.org,jam@chromium.org,leon.han@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=717377, 717378 Review-Url: https://codereview.chromium.org/2882613002 Cr-Commit-Position: refs/heads/master@{#471246} Committed: https://chromium.googlesource.com/chromium/src/+/7795bff0b81a0cd0a8f840357545f591d0cdf6b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -222 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +3 lines, -6 lines 0 comments Download
D content/browser/vibration_browsertest.cc View 1 chunk +0 lines, -90 lines 0 comments Download
M content/test/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M services/service_manager/public/cpp/binder_registry.h View 2 chunks +3 lines, -8 lines 0 comments Download
M services/service_manager/public/cpp/binder_registry.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M services/service_manager/public/cpp/interface_binder.h View 2 chunks +1 line, -8 lines 0 comments Download
M services/service_manager/public/cpp/interface_binder.cc View 2 chunks +4 lines, -27 lines 0 comments Download
M services/service_manager/public/cpp/service_context.h View 2 chunks +0 lines, -15 lines 0 comments Download
M services/service_manager/public/cpp/service_context.cc View 3 chunks +0 lines, -57 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
henrika (OOO until Aug 14)
Created Revert of Enable overriding interface binders for any services running in current process.
3 years, 7 months ago (2017-05-12 07:59:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882613002/1
3 years, 7 months ago (2017-05-12 08:00:10 UTC) #3
henrika (OOO until Aug 14)
[ RUN ] VibrationTest.Vibrate [7018:7018:0511/221018.273968:24891087465:WARNING:audio_manager.cc(293)] Multiple instances of AudioManager detected [7018:7018:0511/221018.274260:24891087628:WARNING:audio_manager.cc(254)] Multiple instances of AudioManager ...
3 years, 7 months ago (2017-05-12 08:00:34 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 08:00:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7795bff0b81a0cd0a8f840357545...

Powered by Google App Engine
This is Rietveld 408576698