Chromium Code Reviews
DescriptionRevert of Enable overriding interface binders for any services running in current process. (patchset #5 id:130001 of https://codereview.chromium.org/2859343003/ )
Reason for revert:
VibrationTest.Vibrate times out in browser_side_navigation_content_browsertests on Linux.
See https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Tests__dbg__1_%2F63093%2F%2B%2Frecipes%2Fsteps%2Fbrowser_side_navigation_content_browsertests%2F0%2Fstdout
Similar issues were found on many different platforms.
Original issue's description:
> Enable overriding interface binders for any services running in current process.
>
> This CL
> - holds a 'service name <--> binder registry' map inside
> service manager client library, at run time it acts as a global
> variable in any process linking with service manager client library.
> - lets ServiceContext::OnBindInterface() use the global map to
> intercept requests before dispatching them to target Services, that
> is to say, such interception may happen for any Services running in
> current process.
> - exposes {SetGlobalBinder,ClearGlobalBinders}ForTesting to set/clear
> binders in the global map.
> - adds a VibrationTest browser test to show the usage of the new infra
> described above.
>
> BUG=717377, 717378
> TEST=content_browsertests
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Review-Url: https://codereview.chromium.org/2859343003
> Cr-Commit-Position: refs/heads/master@{#471216}
> Committed: https://chromium.googlesource.com/chromium/src/+/d25e37df0f08a754fbc11041451a5ce7ca7d043d
TBR=rockot@chromium.org,blundell@chromium.org,jam@chromium.org,leon.han@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=717377, 717378
Review-Url: https://codereview.chromium.org/2882613002
Cr-Commit-Position: refs/heads/master@{#471246}
Committed: https://chromium.googlesource.com/chromium/src/+/7795bff0b81a0cd0a8f840357545f591d0cdf6b0
Patch Set 1 #Messages
Total messages: 8 (4 generated)
|