Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2882523002: Remove SequencedWorkerPool::PostDelayedWorkerTask(). (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
gab
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SequencedWorkerPool::PostDelayedWorkerTask(). There are no more callers of this method. BUG=667892 Review-Url: https://codereview.chromium.org/2882523002 Cr-Commit-Position: refs/heads/master@{#472194} Committed: https://chromium.googlesource.com/chromium/src/+/940082f0cb8fa26ab9d92603b9810a1de3ae4eac

Patch Set 1 #

Patch Set 2 : CR-gab-7 #

Total comments: 2

Patch Set 3 : CR-gab-12 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -28 lines) Patch
M base/threading/sequenced_worker_pool.h View 1 1 chunk +0 lines, -13 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 1 2 3 chunks +5 lines, -12 lines 0 comments Download
M base/threading/sequenced_worker_pool_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
fdoray
PTAL
3 years, 7 months ago (2017-05-11 18:09:22 UTC) #3
gab
Why not just remove it? What I meant was to make overrides private earlier in ...
3 years, 7 months ago (2017-05-12 18:15:44 UTC) #7
fdoray
PTAnL
3 years, 7 months ago (2017-05-16 13:38:33 UTC) #10
gab
lgtm https://codereview.chromium.org/2882523002/diff/20001/base/threading/sequenced_worker_pool.cc File base/threading/sequenced_worker_pool.cc (right): https://codereview.chromium.org/2882523002/diff/20001/base/threading/sequenced_worker_pool.cc#newcode1606 base/threading/sequenced_worker_pool.cc:1606: return inner_->PostTask(NULL, SequenceToken(), shutdown_behavior, from_here, nullptr
3 years, 7 months ago (2017-05-16 15:18:42 UTC) #12
fdoray
https://codereview.chromium.org/2882523002/diff/20001/base/threading/sequenced_worker_pool.cc File base/threading/sequenced_worker_pool.cc (right): https://codereview.chromium.org/2882523002/diff/20001/base/threading/sequenced_worker_pool.cc#newcode1606 base/threading/sequenced_worker_pool.cc:1606: return inner_->PostTask(NULL, SequenceToken(), shutdown_behavior, from_here, On 2017/05/16 15:18:42, gab ...
3 years, 7 months ago (2017-05-16 15:26:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882523002/40001
3 years, 7 months ago (2017-05-16 15:26:29 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/456014)
3 years, 7 months ago (2017-05-16 17:19:19 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882523002/40001
3 years, 7 months ago (2017-05-16 18:45:28 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 19:47:39 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/940082f0cb8fa26ab9d92603b981...

Powered by Google App Engine
This is Rietveld 408576698