Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2882483002: Re-located duplicated service worker test (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-located duplicated service worker test The Web Platform Tests project maintains a more rigorous version of this test, but because that version currently fails in Chromium, this version cannot be removed without negatively effecting test coverage. Re-name the test file and add an in-line comment to document the test's deprecated status. BUG=688116, 507169 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2882483002 Cr-Commit-Position: refs/heads/master@{#471350} Committed: https://chromium.googlesource.com/chromium/src/+/036a8648e3fee70b4414d0567fdf278ece77ce8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
A + third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.performance-timeline.html View 1 chunk +4 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/performance-timeline.html View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mike3
Hi Mek, Here's a diff of the two service worker files: https://gist.github.com/jugglinmike/34768d1d2c44fad49c766b740d209547 As described by ...
3 years, 7 months ago (2017-05-11 16:29:04 UTC) #1
falken
lgtm
3 years, 7 months ago (2017-05-12 04:39:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882483002/1
3 years, 7 months ago (2017-05-12 15:20:49 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 17:27:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/036a8648e3fee70b4414d0567fdf...

Powered by Google App Engine
This is Rietveld 408576698