[Web Payments] UI tweaks to desktop editors

[Web Payments] UI tweaks to desktop editors

Move "Field is required" to content of editors
Change Cancel button in editors to "Cancel Payment"

BUG=718548
Review-Url: https://codereview.chromium.org/2882463002
Cr-Commit-Position: refs/heads/master@{#471157}
Committed: https://chromium.googlesource.com/chromium/src/+/ed59882df38c70c6801b67478454fa00f432d62d

[anthonyvd, 2017-05-11 16:13:50]

anthonyvd@chromium.org changed reviewers:
+ mathp@chromium.org

[anthonyvd, 2017-05-11 16:13:51]

Hi Math, PTAL.

[Mathieu, 2017-05-11 18:15:14]

rebase?

https://codereview.chromium.org/2882463002/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/editor_view_controller.cc (right):

https://codereview.chromium.org/2882463002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/editor_view_controller.cc:208: for (const auto&
field : fields) {
no curlz

https://codereview.chromium.org/2882463002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/editor_view_controller.cc:220:
views::ColumnSet* required_field_columns = editor_layout->AddColumnSet(1);
I think you'll need a big rebase

[anthonyvd, 2017-05-11 21:05:07]

The CQ bit was checked by anthonyvd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 21:06:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[anthonyvd, 2017-05-11 21:21:23]

The CQ bit was checked by anthonyvd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 21:21:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[anthonyvd, 2017-05-11 21:21:51]

Comments addressed. Rebase wasn't so bad ^_^

PTAL?

https://codereview.chromium.org/2882463002/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/editor_view_controller.cc (right):

https://codereview.chromium.org/2882463002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/editor_view_controller.cc:208: for (const auto&
field : fields) {
On 2017/05/11 at 18:15:14, Mathieu wrote:
> no curlz

Done.

https://codereview.chromium.org/2882463002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/editor_view_controller.cc:220:
views::ColumnSet* required_field_columns = editor_layout->AddColumnSet(1);
On 2017/05/11 at 18:15:14, Mathieu wrote:
> I think you'll need a big rebase

Done.

[commit-bot: I haz the power, 2017-05-11 22:01:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 22:01:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mathieu, 2017-05-12 00:28:32]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-05-12 00:28:32]

lgtm

[commit-bot: I haz the power, 2017-05-12 00:30:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 01:00:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494548912259090,
"parent_rev": "0e283fb794e782da9af62dac7cd2aa8800db359a", "commit_rev":
"ed59882df38c70c6801b67478454fa00f432d62d"}

[commit-bot: I haz the power, 2017-05-12 01:00:15]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494548912259090,
"parent_rev": "0e283fb794e782da9af62dac7cd2aa8800db359a", "commit_rev":
"ed59882df38c70c6801b67478454fa00f432d62d"}

[commit-bot: I haz the power, 2017-05-12 01:00:17]

Description was changed from

==========
[Web Payments] UI tweaks to desktop editors

Move "Field is required" to content of editors
Change Cancel button in editors to "Cancel Payment"

BUG=718548
==========

to

==========
[Web Payments] UI tweaks to desktop editors

Move "Field is required" to content of editors
Change Cancel button in editors to "Cancel Payment"

BUG=718548

Review-Url: https://codereview.chromium.org/2882463002
Cr-Commit-Position: refs/heads/master@{#471157}
Committed:
https://chromium.googlesource.com/chromium/src/+/ed59882df38c70c6801b67478454...
==========

[commit-bot: I haz the power, 2017-05-12 01:00:23]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ed59882df38c70c6801b67478454...