Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2882453003:
Fix the module IDs from the Mac stack sampler. (Closed)
|
Created:
3 years, 7 months ago by Avi (use Gerrit) Modified:
3 years, 7 months ago Reviewers:
Mike Wittman CC:
chromium-reviews, danakj+watch_chromium.org, mac-reviews_chromium.org, vmpstr+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix the module IDs from the Mac stack sampler.
On Windows, they are the GUID + age field. On the Mac there is no age field, so 0 should be appended always.
While we're here, also move to a safer string handling function.
BUG=531673
Review-Url: https://codereview.chromium.org/2882453003
Cr-Commit-Position: refs/heads/master@{#471346}
Committed: https://chromium.googlesource.com/chromium/src/+/d31013d806afc0c5dce0c24e40c30f97a4adf972
Patch Set 1 #Patch Set 2 : comment tweak #Patch Set 3 : strlcpy #Messages
Total messages: 21 (16 generated)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
avi@chromium.org changed reviewers: + wittman@chromium.org
lgtm Do you want to address Alexei's drive-by from the last review while we're at it? https://codereview.chromium.org/2848683006/diff/40001/base/profiler/native_st...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix the module IDs from the Mac stack sampler. On Windows, they are the GUID + age field. On the Mac there is no age field, so 0 should be appended always. BUG=531673 ========== to ========== Fix the module IDs from the Mac stack sampler. On Windows, they are the GUID + age field. On the Mac there is no age field, so 0 should be appended always. While we're here, also move to a safer string handling function. BUG=531673 ==========
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
OK
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by avi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wittman@chromium.org Link to the patchset: https://codereview.chromium.org/2882453003/#ps40001 (title: "strlcpy")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494608421921540,
"parent_rev": "11053a39ea015b23c85a394027846b439847b0dd", "commit_rev":
"d31013d806afc0c5dce0c24e40c30f97a4adf972"}
Message was sent while issue was closed.
Description was changed from ========== Fix the module IDs from the Mac stack sampler. On Windows, they are the GUID + age field. On the Mac there is no age field, so 0 should be appended always. While we're here, also move to a safer string handling function. BUG=531673 ========== to ========== Fix the module IDs from the Mac stack sampler. On Windows, they are the GUID + age field. On the Mac there is no age field, so 0 should be appended always. While we're here, also move to a safer string handling function. BUG=531673 Review-Url: https://codereview.chromium.org/2882453003 Cr-Commit-Position: refs/heads/master@{#471346} Committed: https://chromium.googlesource.com/chromium/src/+/d31013d806afc0c5dce0c24e40c3... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/d31013d806afc0c5dce0c24e40c3... |
