Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2882343002: DevTools: Make flamechart coloring depend on group by selector. (Closed)

Created:
3 years, 7 months ago by alph
Modified:
3 years, 7 months ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Make flamechart coloring depend on group by selector. This is currently implemented for Group by Product only and hidden behind an experiment. BUG=718655 Review-Url: https://codereview.chromium.org/2882343002 Cr-Commit-Position: refs/heads/master@{#472161} Committed: https://chromium.googlesource.com/chromium/src/+/2ccf86ba657e1450597a26bb941bd332eff3ab8c

Patch Set 1 #

Patch Set 2 : minor tweaks #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -43 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js View 1 2 chunks +28 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 2 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
alph
3 years, 7 months ago (2017-05-15 23:15:27 UTC) #2
caseq
Looks good modulo UX -- I think it's weird to control flamechart by a combo-box ...
3 years, 7 months ago (2017-05-15 23:27:14 UTC) #4
pfeldman
lgtm
3 years, 7 months ago (2017-05-16 00:28:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882343002/40001
3 years, 7 months ago (2017-05-16 01:23:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/368567) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 7 months ago (2017-05-16 01:45:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882343002/40001
3 years, 7 months ago (2017-05-16 03:38:51 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/427545)
3 years, 7 months ago (2017-05-16 05:27:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882343002/40001
3 years, 7 months ago (2017-05-16 16:41:01 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 18:10:22 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2ccf86ba657e1450597a26bb941b...

Powered by Google App Engine
This is Rietveld 408576698