Factor FrameData out of RendererCompositorFrameSink

Factor FrameData out of RendererCompositorFrameSink

The same struct that holds surface information in 
RendererCompositorFrameSink will be used in the browser and sent over
IPC in future CLs. This CL factors it out and also adds IPC param traits.

Review-Url: https://codereview.chromium.org/2882303002
Cr-Commit-Position: refs/heads/master@{#472506}
Committed: https://chromium.googlesource.com/chromium/src/+/a1d159d88e6b302061a629bdc368609ba50b08b6

[Saman Sami, 2017-05-15 20:17:42]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 20:18:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-05-15 20:19:46]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 20:20:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-05-15 20:29:01]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2017-05-15 20:29:02]

lgtm

https://codereview.chromium.org/2882303002/diff/20001/content/common/render_w...
File content/common/render_widget_surface_properties.h (right):

https://codereview.chromium.org/2882303002/diff/20001/content/common/render_w...
content/common/render_widget_surface_properties.h:12: struct
RenderWidgetSurfaceProperties {
nit: Class level description.

[Saman Sami, 2017-05-15 20:35:28]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 20:36:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-05-15 20:39:05]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 20:40:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 20:56:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 20:56:55]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Saman Sami, 2017-05-15 21:10:08]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 21:11:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 21:40:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 21:40:37]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Saman Sami, 2017-05-15 21:42:21]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 21:43:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 22:06:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 22:06:14]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Saman Sami, 2017-05-15 22:35:59]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 22:37:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 22:54:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 22:54:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Saman Sami, 2017-05-15 23:05:31]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 23:06:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 23:26:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 23:26:12]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Saman Sami, 2017-05-16 01:20:32]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 01:21:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 01:45:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 01:45:55]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Saman Sami, 2017-05-16 21:52:32]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 21:53:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 23:35:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:35:50]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Saman Sami, 2017-05-17 15:01:55]

Description was changed from

==========
Factor FrameData out of RendererCompositorFrameSink

The struct that holds the information for the current surface in
RendererCompositorFrameSink is going to be used in the browser too and
will be a part of several IPC messages. This CL factors it out and also
adds IPC param traits.
==========

to

==========
Factor FrameData out of RendererCompositorFrameSink

The same struct that holds surface information in 
RendererCompositorFrameSink will be used in the browser and sent over
IPC. This CL factors it out and also adds IPC param traits.
==========

[Saman Sami, 2017-05-17 15:02:11]

samans@chromium.org changed reviewers:
+ piman@chromium.org

[Saman Sami, 2017-05-17 15:02:55]

Description was changed from

==========
Factor FrameData out of RendererCompositorFrameSink

The same struct that holds surface information in 
RendererCompositorFrameSink will be used in the browser and sent over
IPC. This CL factors it out and also adds IPC param traits.
==========

to

==========
Factor FrameData out of RendererCompositorFrameSink

The same struct that holds surface information in 
RendererCompositorFrameSink will be used in the browser and sent over
IPC in future CLs. This CL factors it out and also adds IPC param traits.
==========

[Saman Sami, 2017-05-17 15:03:42]

piman, please review content/.

[Saman Sami, 2017-05-17 15:03:50]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Saman Sami, 2017-05-17 15:04:07]

samans@chromium.org changed reviewers:
+ tsepez@chromium.org

[commit-bot: I haz the power, 2017-05-17 15:04:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-05-17 15:04:33]

tsepez, please review IPC.

[piman, 2017-05-17 15:14:06]

lgtm

https://codereview.chromium.org/2882303002/diff/180001/content/common/render_...
File content/common/render_widget_surface_properties.h (right):

https://codereview.chromium.org/2882303002/diff/180001/content/common/render_...
content/common/render_widget_surface_properties.h:20:
RenderWidgetSurfaceProperties(const RenderWidgetSurfaceProperties& other);
nit: also add operator =(const RenderWidgetSurfaceProperties& other)
(rule-of-3)

[Saman Sami, 2017-05-17 15:38:08]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 15:38:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-05-17 15:38:53]

https://codereview.chromium.org/2882303002/diff/180001/content/common/render_...
File content/common/render_widget_surface_properties.h (right):

https://codereview.chromium.org/2882303002/diff/180001/content/common/render_...
content/common/render_widget_surface_properties.h:20:
RenderWidgetSurfaceProperties(const RenderWidgetSurfaceProperties& other);
On 2017/05/17 15:14:06, piman wrote:
> nit: also add operator =(const RenderWidgetSurfaceProperties& other)
> (rule-of-3)

Done.

[Tom Sepez, 2017-05-17 16:00:56]

lgtm

[Saman Sami, 2017-05-17 16:07:21]

The CQ bit was unchecked by samans@chromium.org

[Saman Sami, 2017-05-17 16:07:26]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-05-17 16:07:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2882303002/#ps200001
(title: "c")

[commit-bot: I haz the power, 2017-05-17 16:07:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 18:27:25]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1495037246181420,
"parent_rev": "44ba9092273b822880e06cef6c59a24d40c9df05", "commit_rev":
"a1d159d88e6b302061a629bdc368609ba50b08b6"}

[commit-bot: I haz the power, 2017-05-17 18:27:36]

Description was changed from

==========
Factor FrameData out of RendererCompositorFrameSink

The same struct that holds surface information in 
RendererCompositorFrameSink will be used in the browser and sent over
IPC in future CLs. This CL factors it out and also adds IPC param traits.
==========

to

==========
Factor FrameData out of RendererCompositorFrameSink

The same struct that holds surface information in 
RendererCompositorFrameSink will be used in the browser and sent over
IPC in future CLs. This CL factors it out and also adds IPC param traits.

Review-Url: https://codereview.chromium.org/2882303002
Cr-Commit-Position: refs/heads/master@{#472506}
Committed:
https://chromium.googlesource.com/chromium/src/+/a1d159d88e6b302061a629bdc368...
==========

[commit-bot: I haz the power, 2017-05-17 18:27:38]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/a1d159d88e6b302061a629bdc368...