Chromium Code Reviews
Help | Chromium Project | Sign in
(1033)

Issue 28823003: WIP: Disable warning C4996 for Win SDK 8.1 for all (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months ago by Yoshi
Modified:
2 weeks, 2 days ago
Reviewers:
cpu_(out until 23rd), scottmg, adibu2008, Will Harris
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

Disable warning C4996 for Win SDK 8.1

This patch disables warning C4996 for MSVS2013, which is caused by using deprecated Windows API GetVersion() and GetVersionEx().

BUG=311488
TEST=n/a; no behavior changes

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Lint Patch
M build/common.gypi View 1 chunk +4 lines, -0 lines 2 comments ? errors Download
Commit:

Messages

Total messages: 16
Will Harris
https://codereview.chromium.org/28823003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/28823003/diff/1/build/common.gypi#newcode4394 build/common.gypi:4394: 'msvs_disabled_warnings': [4996] this turns off warnings for all deprecated ...
6 months ago #1
Yoshi
On 2013/10/18 11:37:57, Will Harris wrote: > https://codereview.chromium.org/28823003/diff/1/build/common.gypi > File build/common.gypi (right): > > https://codereview.chromium.org/28823003/diff/1/build/common.gypi#newcode4394 ...
6 months ago #2
scottmg
I didn't encounter these warnings when building on VS2013, http://crbug.com/288948. Can you paste the warnings ...
6 months ago #3
scottmg
https://codereview.chromium.org/28823003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/28823003/diff/1/build/common.gypi#newcode4392 build/common.gypi:4392: ['MSVS_VERSION=="2013"', { needs 'or MSVS_VERSION=="2013e"' also. If it's mostly ...
6 months ago #4
Yoshi
On 2013/10/18 16:09:00, scottmg wrote: > I didn't encounter these warnings when building on VS2013, ...
5 months, 4 weeks ago #5
Yoshi
5 months, 4 weeks ago #6
cpu_(out until 23rd)
We haven't decided if we want to support the win8.1 sdk, moving from win7 sdk ...
5 months, 3 weeks ago #7
scottmg
(Please update the CL description to say 8.1 SDK rather than VS2013 too)
5 months, 3 weeks ago #8
Yoshi
On 2013/10/21 18:01:30, cpu wrote: > We haven't decided if we want to support the ...
5 months, 3 weeks ago #9
Will Harris
On 2013/10/22 03:49:57, Yoshifumi Inoue wrote: > On 2013/10/21 18:01:30, cpu wrote: > > We ...
5 months, 3 weeks ago #10
cpu_(out until 23rd)
Ok lets do this. lgtm This does not mean we are endorsing the use of ...
5 months, 3 weeks ago #11
Yoshi
Is there way to check Win SDK version in gyp file? MSVS=2013 doesn't imply Win ...
5 months, 3 weeks ago #12
scottmg
On 2013/10/24 01:44:16, Yoshifumi Inoue wrote: > Is there way to check Win SDK version ...
5 months, 3 weeks ago #13
Yoshi
scottmg@, thanks for information. I'll write has_str.py then ['OS=="win" and chromium_code==0 and "<!(python <(DEPTH)/build/has_str.py <_WIN32_WINNT_WINBLUE ...
5 months, 3 weeks ago #14
scottmg
On 2013/10/24 04:21:04, Yoshifumi Inoue wrote: > scottmg@, thanks for information. > > I'll write ...
5 months, 3 weeks ago #15
adibu2008_gmail.com
2 weeks, 2 days ago #16

On Sunday, October 20, 2013 9:35:37 PM UTC-4, yo...@chromium.org wrote:
>
> https://codereview.chromium.org/28823003/ 
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434