Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 28823002: [CSS Grid Layout] Do log(n) search in the named line vectors when positioning named line spans (Closed)

Created:
7 years, 2 months ago by Xan
Modified:
7 years, 2 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Grid Layout] Do log(n) search in the named line vectors when positioning named line spans Implement the suggested FIXMEs and do a log search in the named line vectors. This maintains the previous (somewhat tricky) behavior by using std::lower_bound and std::upper_bound. No difference in existing performance tests, but should scale much better for big grids. BUG=303217 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160187

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M Source/core/rendering/RenderGrid.cpp View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Julien - ping for review
lgtm
7 years, 2 months ago (2013-10-18 14:19:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xan@igalia.com/28823002/1
7 years, 2 months ago (2013-10-18 14:19:58 UTC) #2
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=12298
7 years, 2 months ago (2013-10-18 21:17:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xan@igalia.com/28823002/1
7 years, 2 months ago (2013-10-21 15:51:25 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=12729
7 years, 2 months ago (2013-10-21 18:03:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xan@igalia.com/28823002/1
7 years, 2 months ago (2013-10-22 07:24:32 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 11:29:12 UTC) #7
Message was sent while issue was closed.
Change committed as 160187

Powered by Google App Engine
This is Rietveld 408576698