Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2882263002: DevTools: JS color theme bikeshedding (Closed)

Created:
3 years, 7 months ago by paulirish
Modified:
3 years, 7 months ago
Reviewers:
dgozman, lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: JS color theme bikeshedding BUG=721986 Review-Url: https://codereview.chromium.org/2882263002 Cr-Commit-Position: refs/heads/master@{#471889} Committed: https://chromium.googlesource.com/chromium/src/+/92abf957cbc29e3d166b20a1f0b7d66b0e86a5dc

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : globals are black. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
paulirish
No more teal. Variables are consistent (dark blue) Operators are burnt sienna. Two views of ...
3 years, 7 months ago (2017-05-15 18:04:41 UTC) #2
paulirish
updated w/ black globals: http://imgur.com/PACKkEn
3 years, 7 months ago (2017-05-15 18:27:17 UTC) #3
dgozman
lgtm
3 years, 7 months ago (2017-05-15 18:49:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882263002/60001
3 years, 7 months ago (2017-05-15 18:53:11 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 20:42:10 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/92abf957cbc29e3d166b20a1f0b7...

Powered by Google App Engine
This is Rietveld 408576698