Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2882243003: Updated Robolectric documentation. (Closed)

Created:
3 years, 7 months ago by mikecase (-- gone --)
Modified:
3 years, 7 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated Robolectric documentation. Now that change to expose resources to Robolectric tests has landed, I wanted to update the documentation to point out to people they need to specify "package_name" GN variable to get it to work (since that is definitely not obvious). You can also (theoretically) now specify the AndroidManifest.xml file to Robolectric (Robolectric will grab the package name from there). However, no tests currently do this. Review-Url: https://codereview.chromium.org/2882243003 Cr-Commit-Position: refs/heads/master@{#472156} Committed: https://chromium.googlesource.com/chromium/src/+/5e8650321a3058567af36d42faf2618d93743e59

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated Robolectric documentation. #

Patch Set 3 : Updated Robolectric documentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M testing/android/docs/junit.md View 1 2 2 chunks +27 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mikecase (-- gone --)
3 years, 7 months ago (2017-05-15 22:38:24 UTC) #2
jbudorick
lgtm w/ nits https://codereview.chromium.org/2882243003/diff/1/testing/android/docs/junit.md File testing/android/docs/junit.md (right): https://codereview.chromium.org/2882243003/diff/1/testing/android/docs/junit.md#newcode57 testing/android/docs/junit.md:57: your own. They work like this; ...
3 years, 7 months ago (2017-05-15 22:56:53 UTC) #3
mikecase (-- gone --)
Fixed all the nits. From now on, going to write documentation in Docs (apparently I ...
3 years, 7 months ago (2017-05-16 17:37:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882243003/40001
3 years, 7 months ago (2017-05-16 17:38:24 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 18:05:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5e8650321a3058567af36d42faf2...

Powered by Google App Engine
This is Rietveld 408576698