Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 2882243002: Remove ChromeWebApkHost::GetGooglePlayInstallState() check from WebApkInstaller (Closed)

Created:
3 years, 7 months ago by pkotwicz
Modified:
3 years, 7 months ago
Reviewers:
Xi Han, Yaron
CC:
chromium-reviews, zpeng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ChromeWebApkHost::GetGooglePlayInstallState() check from WebApkInstaller In the install path: GetGooglePlayInstallState() == GooglePlayInstallState::SUPPORTED is checked via ChromeWebApkHost::CanCanInstallWebApk() in add_to_homescreen_manager.cc and app_banner_manager_android.cc In the update path: GetGooglePlayInstallState() == GooglePlayInstallState::SUPPORTED is not checked. However: - it should be impossible for the WebAPK to be installed if ChromeWebApkHost::CanCanInstallWebApk() does not return true - updates don't show any UI BUG=722178 Review-Url: https://codereview.chromium.org/2882243002 Cr-Commit-Position: refs/heads/master@{#472126} Committed: https://chromium.googlesource.com/chromium/src/+/5413280afdd44bd90e6dc90bd7a09090a9743290

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -43 lines) Patch
M chrome/browser/android/webapk/webapk_installer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/android/webapk/webapk_installer.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/android/webapk/webapk_installer_unittest.cc View 7 chunks +7 lines, -30 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
pkotwicz
Xi can you please take a look? This CL has a negligible impact on install ...
3 years, 7 months ago (2017-05-15 14:40:15 UTC) #2
Xi Han
lgtm
3 years, 7 months ago (2017-05-16 14:17:36 UTC) #3
pkotwicz
Yaron for OWNERS
3 years, 7 months ago (2017-05-16 15:26:00 UTC) #5
Yaron
lgtm
3 years, 7 months ago (2017-05-16 15:30:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882243002/1
3 years, 7 months ago (2017-05-16 15:40:33 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 16:21:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5413280afdd44bd90e6dc90bd7a0...

Powered by Google App Engine
This is Rietveld 408576698