Chromium Code Reviews
DescriptionRemove ChromeWebApkHost::GetGooglePlayInstallState() check from WebApkInstaller
In the install path:
GetGooglePlayInstallState() == GooglePlayInstallState::SUPPORTED
is checked via ChromeWebApkHost::CanCanInstallWebApk() in
add_to_homescreen_manager.cc and app_banner_manager_android.cc
In the update path:
GetGooglePlayInstallState() == GooglePlayInstallState::SUPPORTED
is not checked. However:
- it should be impossible for the WebAPK to be installed if
ChromeWebApkHost::CanCanInstallWebApk() does not return true
- updates don't show any UI
BUG=722178
Review-Url: https://codereview.chromium.org/2882243002
Cr-Commit-Position: refs/heads/master@{#472126}
Committed: https://chromium.googlesource.com/chromium/src/+/5413280afdd44bd90e6dc90bd7a09090a9743290
Patch Set 1 #
Messages
Total messages: 11 (5 generated)
|
|||||||||||||||||||||||||||||||||||||