[inspector] move continueToLocation implementation to debugger

[inspector] move continueToLocation implementation to debugger

So continue to location can be called only for one context group id at the same time.

BUG=v8:6397
Review-Url: https://codereview.chromium.org/2882213004
Cr-Commit-Position: refs/heads/master@{#45349}
Committed: https://chromium.googlesource.com/v8/v8/+/4d67e3562472fcfeac6b93882d0e35cf0a06129e

[kozy, 2017-05-16 00:16:14]

kozyatinskiy@chromium.org changed reviewers:
+ dgozman@chromium.org

[kozy, 2017-05-16 00:16:14]

Dmitry, please take a look! It's preparation.

[dgozman, 2017-05-16 18:51:04]

lgtm

https://codereview.chromium.org/2882213004/diff/20001/src/inspector/v8-debugg...
File src/inspector/v8-debugger-agent-impl.cc (left):

https://codereview.chromium.org/2882213004/diff/20001/src/inspector/v8-debugg...
src/inspector/v8-debugger-agent-impl.cc:500: // TODO(kozyatinskiy): Return
actual line and column number.
Keep this todo?

https://codereview.chromium.org/2882213004/diff/20001/src/inspector/v8-debugg...
File src/inspector/v8-debugger.cc (right):

https://codereview.chromium.org/2882213004/diff/20001/src/inspector/v8-debugg...
src/inspector/v8-debugger.cc:433: return Response::Error("No breakpoint by
passed location");
Cannot continue to specified location

https://codereview.chromium.org/2882213004/diff/20001/src/inspector/v8-debugg...
src/inspector/v8-debugger.cc:441: m_continueToLocationBreakpointId = String16();
Move this under if?

[kozy, 2017-05-16 19:01:16]

thanks, all done!

https://codereview.chromium.org/2882213004/diff/20001/src/inspector/v8-debugg...
File src/inspector/v8-debugger-agent-impl.cc (left):

https://codereview.chromium.org/2882213004/diff/20001/src/inspector/v8-debugg...
src/inspector/v8-debugger-agent-impl.cc:500: // TODO(kozyatinskiy): Return
actual line and column number.
On 2017/05/16 18:51:04, dgozman wrote:
> Keep this todo?

Done.

https://codereview.chromium.org/2882213004/diff/20001/src/inspector/v8-debugg...
File src/inspector/v8-debugger.cc (right):

https://codereview.chromium.org/2882213004/diff/20001/src/inspector/v8-debugg...
src/inspector/v8-debugger.cc:433: return Response::Error("No breakpoint by
passed location");
On 2017/05/16 18:51:04, dgozman wrote:
> Cannot continue to specified location

Done.

https://codereview.chromium.org/2882213004/diff/20001/src/inspector/v8-debugg...
src/inspector/v8-debugger.cc:441: m_continueToLocationBreakpointId = String16();
On 2017/05/16 18:51:04, dgozman wrote:
> Move this under if?

Done.

[kozy, 2017-05-16 19:01:20]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-05-16 19:01:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-05-16 19:01:35]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-05-16 19:01:35]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2882213004/#ps40001
(title: "ac")

[commit-bot: I haz the power, 2017-05-16 19:01:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 19:34:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494961295379230,
"parent_rev": "b056073000ae72156417b468bb72b7c8a43bd009", "commit_rev":
"4d67e3562472fcfeac6b93882d0e35cf0a06129e"}

[commit-bot: I haz the power, 2017-05-16 19:34:32]

Description was changed from

==========
[inspector] move continueToLocation implementation to debugger

So continue to location can be called only for one context group id at the same
time.

BUG=v8:6397
==========

to

==========
[inspector] move continueToLocation implementation to debugger

So continue to location can be called only for one context group id at the same
time.

BUG=v8:6397

Review-Url: https://codereview.chromium.org/2882213004
Cr-Commit-Position: refs/heads/master@{#45349}
Committed:
https://chromium.googlesource.com/v8/v8/+/4d67e3562472fcfeac6b93882d0e35cf0a0...
==========

[commit-bot: I haz the power, 2017-05-16 19:34:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/4d67e3562472fcfeac6b93882d0e35cf0a0...