Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2882213003: [Offline pages] Reporting correct expiration reason in CleanupTask (Closed)

Created:
3 years, 7 months ago by fgorski
Modified:
3 years, 7 months ago
Reviewers:
Pete Williamson
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Reporting correct expiration reason in CleanupTask BUG=705115 Review-Url: https://codereview.chromium.org/2882213003 Cr-Commit-Position: refs/heads/master@{#472269} Committed: https://chromium.googlesource.com/chromium/src/+/16c45c04cf239a0153842f93c9fa7b5810d0233e

Patch Set 1 #

Total comments: 5

Patch Set 2 : Addressing feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -18 lines) Patch
M components/offline_pages/core/background/cleanup_task.h View 2 chunks +9 lines, -3 lines 0 comments Download
M components/offline_pages/core/background/cleanup_task.cc View 1 5 chunks +38 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
fgorski
PTAL
3 years, 7 months ago (2017-05-15 22:12:37 UTC) #2
Pete Williamson
https://codereview.chromium.org/2882213003/diff/1/components/offline_pages/core/background/cleanup_task.cc File components/offline_pages/core/background/cleanup_task.cc (right): https://codereview.chromium.org/2882213003/diff/1/components/offline_pages/core/background/cleanup_task.cc#newcode69 components/offline_pages/core/background/cleanup_task.cc:69: // If there are not expired requests processing is ...
3 years, 7 months ago (2017-05-15 23:44:19 UTC) #3
fgorski
PTAL https://codereview.chromium.org/2882213003/diff/1/components/offline_pages/core/background/cleanup_task.cc File components/offline_pages/core/background/cleanup_task.cc (right): https://codereview.chromium.org/2882213003/diff/1/components/offline_pages/core/background/cleanup_task.cc#newcode69 components/offline_pages/core/background/cleanup_task.cc:69: // If there are not expired requests processing ...
3 years, 7 months ago (2017-05-16 17:41:51 UTC) #4
Pete Williamson
lgtm https://codereview.chromium.org/2882213003/diff/1/components/offline_pages/core/background/cleanup_task.cc File components/offline_pages/core/background/cleanup_task.cc (right): https://codereview.chromium.org/2882213003/diff/1/components/offline_pages/core/background/cleanup_task.cc#newcode88 components/offline_pages/core/background/cleanup_task.cc:88: auto iter = expired_request_ids_and_reasons_.find(request.request_id()); On 2017/05/16 17:41:51, fgorski ...
3 years, 7 months ago (2017-05-16 18:13:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882213003/20001
3 years, 7 months ago (2017-05-16 18:22:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/446120)
3 years, 7 months ago (2017-05-16 20:59:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882213003/20001
3 years, 7 months ago (2017-05-16 22:05:54 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 00:45:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/16c45c04cf239a0153842f93c9fa...

Powered by Google App Engine
This is Rietveld 408576698