Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1228)

Issue 2882203002: [v8] Manually rebaseline asm.js layout tests. (Closed)

Created:
3 years, 7 months ago by Michael Starzinger
Modified:
3 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[v8] Manually rebaseline asm.js layout tests. Now that a V8 version with the new asm.js validator has been rolled into Chromium, the affected layout tests can be rebased. This feature is not yet enabled. R=machenbach@chromium.org BUG=chromium:718394 Review-Url: https://codereview.chromium.org/2882203002 Cr-Commit-Position: refs/heads/master@{#471740} Committed: https://chromium.googlesource.com/chromium/src/+/30e66e1ff63c37aa4d3e2d1cde170ad95800f2be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/enable_asmjs/http/tests/asmjs/asm-warnings-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Michael Starzinger
PTAL.
3 years, 7 months ago (2017-05-15 12:06:18 UTC) #6
Michael Achenbach
lgtm
3 years, 7 months ago (2017-05-15 12:38:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882203002/1
3 years, 7 months ago (2017-05-15 12:48:59 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 12:53:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/30e66e1ff63c37aa4d3e2d1cde17...

Powered by Google App Engine
This is Rietveld 408576698