Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 2882183002: Thumbnails: Add some perf UMA (Closed)

Created:
6 months, 1 week ago by Marc Treib
Modified:
6 months, 1 week ago
CC:
asvitkine+watch_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Thumbnails: Add some perf UMA BUG=718413 Review-Url: https://codereview.chromium.org/2882183002 Cr-Commit-Position: refs/heads/master@{#472138} Committed: https://chromium.googlesource.com/chromium/src/+/4a79f66a7649512ba0e1cebd1e1d3c3cccb1bdc1

Patch Set 1 #

Total comments: 5

Patch Set 2 : no more using #

Messages

Total messages: 27 (20 generated)
Marc Treib
jochen: Please look at thumbnail_tab_helper.h/cc. (Unfortunately, c/b/thumbnails doesn't have any direct owners.) holte: Please look ...
6 months, 1 week ago (2017-05-15 10:16:48 UTC) #4
Steven Holte
lgtm
6 months, 1 week ago (2017-05-15 22:16:01 UTC) #11
jochen (gone - plz use gerrit)
who would be a good owner for thumbnails code? https://codereview.chromium.org/2882183002/diff/1/chrome/browser/thumbnails/thumbnail_tab_helper.cc File chrome/browser/thumbnails/thumbnail_tab_helper.cc (left): https://codereview.chromium.org/2882183002/diff/1/chrome/browser/thumbnails/thumbnail_tab_helper.cc#oldcode51 chrome/browser/thumbnails/thumbnail_tab_helper.cc:51: ...
6 months, 1 week ago (2017-05-16 11:15:17 UTC) #12
Marc Treib
I don't know who'd be a good owner. From history, it seems this code hasn't ...
6 months, 1 week ago (2017-05-16 11:48:38 UTC) #13
jochen (gone - plz use gerrit)
lgtm
6 months, 1 week ago (2017-05-16 11:50:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882183002/20001
6 months, 1 week ago (2017-05-16 16:30:45 UTC) #24
commit-bot: I haz the power
6 months, 1 week ago (2017-05-16 17:09:41 UTC) #27
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4a79f66a7649512ba0e1cebd1e1d...

Powered by Google App Engine
This is Rietveld efc10ee0f